search

PokeAPI / pokedex-promise-v2

An easy way to use pokeapi v2 with promises in node.js
MIT License
510 stars 89 forks source link

Fix ListEndpointOptions interface in typings file #56

Closed C-Garza closed 2 years ago

C-Garza commented 2 years ago

Should resolve #55. It seems the npm module didn't have a reference to the interface ListEndpointOptions, so I modified the generator file to use the PokeAPI.ListEndpointOptions interface in the index.d.ts file.

Naramsim commented 2 years ago

Hi @C-Garza, thanks as always! Here I kinda trust you because I didn't look too much at the error. I request a review from @HRKings, he'll be much more helpful.

HRKings commented 2 years ago

@C-Garza thanks for looking into this! I didn't receive any notification, sorry! @Naramsim thanks for pinging me!

HRKings commented 2 years ago

@C-Garza while this does fix the issue, it's not the right solution :/ The problem is that I made the ListEndpointOptions interface generate in the wrong place, my bad for this going unnoticed, I've commented the right fix on the original issue, feel free to implement it or if you want to, I could make the PR

C-Garza commented 2 years ago

Oh yes, I see what you were trying to do there in the TypesGenerator file now. I can quickly make the change if you'd like @HRKings.

C-Garza commented 2 years ago

@HRKings I've force pushed the new change you suggested and regenerated the declaration file.

HRKings commented 2 years ago

@C-Garza, nice! Thanks for your work!

Naramsim commented 2 years ago

Thanks guys for the collaboration!

Naramsim commented 2 years ago

@C-Garza, can you bump the version and then merge?

Naramsim commented 2 years ago

@C-Garza @HRKings do you have 2FA on NPM? Can you link me your profiles? So I'll let maintain this package

C-Garza commented 2 years ago

Sure @Naramsim , my here is my NPM profile: C-Garza

HRKings commented 2 years ago

Me too @Naramsim, here it is: HRKings