Open merfed opened 2 years ago
This would be amazing, especially if it included regional variants as well!
Is there a reason to use a Form id instead of a Pokemon Id? Just wondering - I'm not sure if one would be preferable to the other.
What do you guys think about, in addition to the form/variety id, add the version groups ids in which that evolution occurs?
For example: Probopass, it evolves when leveling up in a magnetic field zone, but in Legends Arceus, it evolves with a thunder stone.
You could deduce the version groups since the "pokemon_evolution" has the location_id pointing to those "magnetic field zones" (which are linked to a region, which are linked to version_groups). But how would you know that the "thunder stone" evolution is tied only to Legends Arceus in this case?
BTW, I'm basing myself on Bulbapedia. The evolution data for Magnezone falls on the same problem. But instead of tying the "thunder stone" option to Legends Arceus, it ties to Gen VIII, so I'm not really sure if those should be tied to a version group or a generation.
pokemon_evolution
only tracks evolutions by their species. There is currently no way to track evolutions that change forms. Before I go ahead and make a pull request for this, I'd like to bring it up for discussion.The proposal is, we add an additional column after
evolved_species_id
inpokemon_evolution
namedevolved_form_id
. As well as an additional trigger inevolution_triggers
:Note: I've skipped 11 (our last id is 10 - other), since I'm using that for pokemon-go, and handling Meltan's evolution.
So the proposed additions to
pokemon_evolution
would be:With Mega-Rayquaza being excluded for one reason that the mega evolution occurs after completing the delta-episode and knowing Dragon Ascent. Now, I don't want to tag Mega-Rayquaza's evolution trigger as
other
, because that wouldn't be clear. So possibly adding another trigger for completion of the delta-episode, would be more clear.Should we go that route:
evolution_triggers
pokemon_evolution
This will open up some issues as to how the evolution_chain endpoint handles Pokemon forms, and their form rather than species (or both).