search

PokeAPI / pokedex

PokeAPI's fork for adding gen-8 data.
https://github.com/PokeAPI/pokedex/tree/master-pokeapi/pokeapi
MIT License
43 stars 38 forks source link

Introduce GitHub action #117

Closed giginet closed 2 years ago

giginet commented 2 years ago

Currently, this project doesn't have CI environments šŸ¤•

I recommend introducing CI environment strongly.

So I added GitHub Action environment instead of Travis CI.

This action runs some situations to dump PokƩmon DB.

You have to merge #113 and #116 before to pass these jobs.

Please review them all šŸ™

Naramsim commented 2 years ago

Hi! thanks for the PR! It seems that there are some conflicts that cannot be resolved rising the UI. Could you have a look?

giginet commented 2 years ago

I fixed then it seems to pass all tests šŸŒø

giginet commented 2 years ago

By the way, Can I be a maintainer of this repo?

Recently, Iā€™m developing a PokĆ©mon-related product as a hobby and I use this library. Iā€™m looking forward to Scarlet/Violet. I wish this repo is maintained for future series.

Iā€™m a PokĆ©mon trainer since the first series and I played Sword/Shield for over 1000 hours. I can develop Python and some other programming languages.

Thank you.

Naramsim commented 2 years ago

Hi, sorry, we don't really promote unknown people to the role of maintainer, this is for security reasons. Moreover, this is a fork of Veekun's project. We here, use it only for storing modified CSV files. I guess you are the only one using the Python engine.

giginet commented 2 years ago

I understood. I use this library at my own risk. I wish for future developments.

Naramsim commented 2 years ago

Yeahh, thanks for the contributions but I really doubt there will be any code updates other than to the CSV files :), from us.

But feel free to open as many PR as you want, I'll try to review and merge everything. If you commit, we could invite you as an external collaborator for this project so at least you'll have write access.

Also, I see that you are interested in the upcoming gen9. Are you planning to extract data from the games? If you do, we and Veekun would be really interested in it.