Mr. Rime Egg Groups Reporting Empty

PokeAPI / pokedex

PokeAPI's fork for adding gen-8 data.

https://github.com/PokeAPI/pokedex/tree/master-pokeapi/pokeapi

MIT License

43 stars 40 forks source link

Mr. Rime Egg Groups Reporting Empty #87

Closed JoshPCodes closed 2 years ago

JoshPCodes commented 2 years ago

Executing the Pokemon Species endpoint for Mr. Rime returns an empty list of egg groups. This seems to be incorrect, as Bulbapedia lists it as part of the Human-like (Humanshape) egg group.

To reproduce

Execute the call "https://pokeapi.co/api/v2/pokemon-species/mr-rime"
Check out the egg_groups attribute. It lists 0 entries.

Expectation: The egg_groups list would contain a single entry for "humanshape"

Naramsim commented 2 years ago

We probably lack that data. Would you be willing to contribute?

JoshPCodes commented 2 years ago

Hey Naramsim! Definitely not opposed to helping out with this if it isn't terribly taxing, time permitting. Would that require some level of db access? Or is the data updated in a different manner?

Naramsim commented 2 years ago

Hi, no, all the data is available as CSV files. It is here: https://github.com/PokeAPI/pokedex/tree/master-pokeapi/pokedex/data/csv

If you will contribute, I'd like to ask you to wait till this PR https://github.com/PokeAPI/pokedex/pull/86 is merged, otherwise you might have to fix conflicts

JoshPCodes commented 2 years ago

I took a quick scan before I asked, and somehow I missed that directory entirely. My mistake! Thank you for pointing me in the right direction!

It actually looks like PR 86 is adding the data I noticed was missing (added line 1110 in pokemon_egg_groups.csv), amongst its several other changes. If I encounter anything similar going forward, I'll see if I can contribute an update from my end.