Hisui

[anhthang]

I have added some new data for the new Pokemon and new forms introduced in Legends: Arceus

All of this data was collected manually from Bulbapedia (Japanese collected from Zukan)

Not sure what I'm doing is in the right way, or missing anything, so please help me verify if possible, then I can continue and correct it.

[Naramsim]

Hi @anhthang, sorry for the extremely late reply. Thanks infinitely for the additions. I'll have to review a bit the PR and understand how the new update works.

If I understood correctly this data is from the Arceus update, right? So we are still talking about gen 8?

[anhthang]

Hi @Naramsim

Yes, this is gen 8 update from Arceus. So, please review it.

I also find out that some old pokemon has forms (cherrim, shellos, gastrodon, deerling, sawsbuck...), but they're missing pokemon/species id so it's missing in the API too. How we can add it safely? I thought it should be in a order like pokemon_id, is it?

[simonorono]

This is great @anhthang I noticed that the new Pokédex from Hisui, the addition of new Pokémon to the national dex and new moves/learn-sets is missing. Would that block the merging of this PR or can be contributed later? @Naramsim

I could help with those.

[anhthang]

Thanks @simonorono. I'm still waiting feedback from @Naramsim before adding the others. New moves, TM/HM... maybe in another PR.

[Naramsim]

I don't have any time to look into it guys. I'm sorry this has taken ages. Hopefully, I'll reserve some time and try to understand the new generation and the new data. But if there are other core members who are willing to review, then it might be way quicker.

[Naramsim]

If you want we could test this data in our staging environment. Could you open an identical PR towards the staging branch of PokeAPI?

[anhthang]

Hi @Naramsim,

Versions & version groups are updated, pls verify again if you have time.

I also have a question, why some pokemon has forms but they don't have a pokemon_id (like Cherrim, Unown...)

[Naramsim]

Hi @anhthang , thanks so much again! Imho, we can merge. @C-Garza any thoughts?

About the forms: there are forms and varieties. I forgot where the issue describing them is. I should pin it when I find it again.

[C-Garza]

Sorry, I haven't had time to look at this. I actually didn't notice this PR until you pinged me 😅. I can probably take a look at it tomorrow if you haven't already merged it by then.

[anhthang]

just fixed the flavor texts, break lines and sort

[C-Garza]

I left one comment, other than that it looks good to me.

[Naramsim]

Nice, I'll try build pokeapi with this data later

[Naramsim]

Yay! It's working!

[Naramsim]

Can you test a bit? https://staging.pokeapi.co/api/v2/pokemon/?offset=0&limit=200000 @anhthang

[anhthang]

@Naramsim I just fixed a small bug. I think the other is fine to me

[Naramsim]

@anhthang, it's live! Thank you so much for the effort in these months. I know I took quite a while, but we maintainers don't have much time anymore.

Thanks again!

[anhthang]

@Naramsim thank you for your support 💪 can you update graphql also? it seems not updated

[Naramsim]

Ahhh, hahah yeahh, I'll try!!!

[Naramsim]

I've updated the graphql, can you check?

[anhthang]

I've updated the graphql, can you check?

Just tested, it seems working fine except some optional data. I will work on it later if I have time

[bdawg1989]

Was this ever merged and fixed? All of the Hisui mons don't have gen 8 learnsets or moves that I can pull.

[Naramsim]

Yes this was merged