search

PokeAPI / pokekotlin

Kotlin (or Java, Scala, etc) client for PokeApi
Apache License 2.0
172 stars 43 forks source link

RxJava Support #60

Closed r0adkll closed 7 years ago

r0adkll commented 7 years ago

Issue https://github.com/PokeAPI/pokekotlin/issues/59

Added RxJava based API client.

I decided to implement a separate parity to the synchronous client with the same method signatures but returns Observable<..> instead as I wasn't sure if you would prefer this route over a single PokeApiClient route where the methods look something like this:

fun getBerryList(offset: Int, limit: Int): NamedApiResourceList

fun observeBerryList(offset: Int, limit: Int): Observable<NamedApiResourceList>

I thought it cleaner to do separate clients with duplicate method signatures. I am happy to do it either way.

sargunv commented 7 years ago

Thanks, will review it soon.

r0adkll commented 7 years ago

Bump?