PokeAPI / pokekotlin

Kotlin (or Java, Scala, etc) client for PokeApi
Apache License 2.0
171 stars 43 forks source link

added getPokemon by name #34 #68

Closed efenderbosch closed 4 years ago

efenderbosch commented 5 years ago

Get pokemon by name. Partially fulfills #34

I need to query by name since I'll be getting the the name via OCR and need to support forms, such as Alolan.

a2937 commented 5 years ago

Whatever happened to this pull request? Is there still more features that need to be added?

sargunv commented 4 years ago

I don't want to enable unsupported functionality like calling by name, so I won't be merging this. The correct way to do this is to request the actual objects by id to get the names in the correct form, cache that locally, then search that cached list.