PokeAPI / pokekotlin

Kotlin (or Java, Scala, etc) client for PokeApi
Apache License 2.0
172 stars 43 forks source link

Add support for machines and form names #77

Closed sargunv closed 4 years ago

sargunv commented 4 years ago

plus a bit of non-breaking refactoring, mostly in tests

codecov[bot] commented 4 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.13%. The diff coverage is 73.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #77      +/-   ##
============================================
+ Coverage     65.35%   65.49%   +0.13%     
  Complexity      106      106              
============================================
  Files            19       19              
  Lines           866      881      +15     
  Branches          3        3              
============================================
+ Hits            566      577      +11     
- Misses          299      303       +4     
  Partials          1        1              
Impacted Files Coverage Δ Complexity Δ
...rgunvohra/lib/pokekotlin/client/RxPokeApiClient.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...sargunvohra/lib/pokekotlin/client/PokeApiClient.kt 97.05% <50.00%> (-0.95%) 98.00 <1.00> (+1.00) :arrow_down:
...lin/me/sargunvohra/lib/pokekotlin/model/Machine.kt 80.00% <80.00%> (ø) 4.00 <4.00> (?)
...lin/me/sargunvohra/lib/pokekotlin/model/utility.kt 52.17% <80.00%> (ø) 0.00 <0.00> (?)
...otlin/me/sargunvohra/lib/pokekotlin/model/items.kt 80.43% <100.00%> (+0.43%) 0.00 <0.00> (ø)
...otlin/me/sargunvohra/lib/pokekotlin/model/moves.kt 62.35% <100.00%> (+0.44%) 0.00 <0.00> (ø)
...lin/me/sargunvohra/lib/pokekotlin/model/pokemon.kt 69.47% <100.00%> (+0.12%) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19e050f...3ef3215. Read the comment docs.