search

PokeAPI / pokepy

A Python wrapper for PokéAPI
https://pokeapi.co
BSD 3-Clause "New" or "Revised" License
127 stars 27 forks source link

Add windows tests to circleci config #57

Closed Kronopt closed 4 years ago

Naramsim commented 4 years ago

@Kronopt is the below image normal or just a Github glitch? I saw that on CircleCI all the tests passed.

circle

Kronopt commented 4 years ago

I think it has something to do with the settings of this repo (maybe this?) I changed the name of the circleci jobs, so the jobs he's waiting for no longer exist.

Is that something you can change, @Naramsim? Or should I just change the names back? Still, I added a new job that should be added to this list of expected jobs

Naramsim commented 4 years ago

Is it possible @Kronopt to add also a py27-win?

Kronopt commented 4 years ago

The windows image provided by circleci only has python 3.7.7 pre-installed, so that was the one I used.

Initially I wanted to add a windows test for each pokepy supported python version (also for macOs, but that's a paid option...), but circleci doesn't provide a straightforward way to do it as it does with linux-based python dockers. So, yes, I wanted to add a py27-windows job, but I would have to install python 27 on the windows image.

I haven't searched for ways to do that programmatically, so I add just the py37-win job. Do you recommend a way to do it?

Kronopt commented 4 years ago

The windows image has chocolatey installed. Maybe I can use it to install other python versions.

Naramsim commented 4 years ago

It's up to you. If you have time and want to try your welcome to do it, but it's not necessary :)

Sometimes dealing with CI systems can be a pain in the neck, so feel free to let the things how they are now.