search

PokeDevs / pokedex-api

This is an issue only repository for the PokéDex API. You'll also find announcements about the API in the issues.
https://pokedevs.gitbook.io
11 stars 0 forks source link

[Feature Request] Type effectiveness #2

Closed ruchernchong closed 3 years ago

ruchernchong commented 5 years ago

I'm opening this issue because:

Description:

The current API only has the type of Pokemon. It will be great if the API contains properties like effective, resistance as an array.

e.g. Using Pikachu

{
  "effective": ["water", "flying"],
  "resistance": ["ground"]
}
bastion[bot] commented 5 years ago

Congratulations on opening your first issue in this repository. A maintainer will get by as soon as possible to address this issue.

Cheers, Bastion

iamtraction commented 5 years ago

This is a great suggestion. But currently I don't have enough time to collect the required data for it and implement it, so it might take some time for this to be implemented.

Although, if you want to contribute feel free to do hop into our Discord server and we can talk what can be done.

ruchernchong commented 5 years ago

Don't worry. Take your time, just a suggestion anyway, I have no rush for this.

gabejchambers commented 4 years ago

I created a python script that takes in two lists of pokemon and calculates overall effectiveness between the teams based on their type attributes. It is probably not well optimized by any means but I could provide it to anyone as a starting point to automatically tag pokemon with properties for their effectiveness.

If anyone is interested let me know and I can put the code on github. The most helpful part might be a handcoded nested dictionary of all types matched with each other and the respective effectivness to emulate the classic "type effectiveness table" charts.

ruchernchong commented 3 years ago

Since this seemed to have become stale, I will be closing this for now.