PokeMiners / pogo_assets

Repository of all mined assets including sprites, news items, sound files, translations, and 3D Assets for Pokemon GO.
416 stars 116 forks source link

The future of 2D Addressable Assets? #43

Closed BartmanEH closed 1 year ago

BartmanEH commented 1 year ago

Hello Marty et al,

I’ve read your update note. I certainly appreciate where you’re coming from. What a pain that Niantic feels the need to change obfuscation so frequently. None of us can grasp why they are so against enthusiastic players trying to make tools to make the game more enjoyable.

To that end, I’ve been contributing to maintaining a shiny checklist tool that links to images in the pokeminer Addressable Asset GitHub database. You’ll recall recently schooling me about the scratch folder etc. (thanks for that).

Reading between the lines of your update note, I’m curious how obfuscated the 256x256 2D images assets are. Are we quickly going to lose out on new 2D assets as your mining tools cease to work?

Thanks again for your great work. It’s been fun following you and the pokeminer team on Twitter (RIP), I mean X, and using the mined assets for a fun shiny checklist tool.

Bart

P.S. if you could slip the 2D 256x256 Snorlax with Nightcap and Flying Pikachu with Orange Balloons assets into the main Addressable Assets hierarchy, our tool would be up to date at least for now

tlundse commented 1 year ago

I too am using the Addressable Asset from GitHub for similar tools, and am immensely grateful for all the work you have been putting into this over the years. I also feel your pain, and sympathise with you, in every way. I am not asking you to continue working on a project you no longer enjoy working on, but I wanted to make this post to let you know that besides @BartmanEH, there is at least ONE other person who would also love a way to, in the future, be able to access future 2D sprites.

ShinyHunterRob commented 1 year ago

Since we're sharing, I might as well. I also use your Github repo to show GO-specific 'mon sprites on a website I run (www.pokecenterblog.pt, if you're interested). Currently I've been on top of the scratch folder on Google Drive, since that's the place that's been updated the most. Like @tlundse said, there are people who would love a way to access the sprites. Thank you for all that you have done for the community.

marty0678 commented 1 year ago

Thanks for all your comments. :) The last time they changed Pokemon sprites was a few months ago when they changed how their newer asset systems get delivered. Before that, it was a few years before the last change. So probably safe for a while that they won't change things again, but honestly who knows?

I've been meaning to update the main repo from the scratch folder but motivation haha. If anyone wanted to make a PR though moving the assets they need into the addressable asset folder from the scratch folder I can merge it in the meantime. It's nothing fancy, the sprites in the Texture2D folders get moved into the 256 folders and the sprites in the actual sprite folder are moved into the regular Pokemon folder (both under the addressable assets folder in their respective directories).

BartmanEH commented 1 year ago

Well I’ve never done a PR… how exciting! I’m not sure about anything but the 256 stuff, but I’ll have a go

Edit:

the sprites in the Texture2D folders get moved into the 256 folders and the sprites in the actual sprite folder are moved into the regular Pokemon folder (both under the addressable assets folder in their respective directories).

I copied the two assets from the Texture2D folders into the 256 folder but I don’t know what the ‘sprites’ are as I’ve never referenced them.

I made a PR (my first ever) for the two assets referenced in the OP.

marty0678 commented 1 year ago

Cool thanks! Merged.

BartmanEH commented 1 year ago

Well I messed up: looks like I added Images/Pokemon - 256x256/Addressable Assets/pm143.cNIGHTCAP.s.icon.png.png but of course it should be Images/Pokemon - 256x256/Addressable Assets/pm143.cNIGHTCAP.s.icon.png let me see if I can PR that change.

Edit: I think I figured it out; deleted improperly named file and uploaded properly named file and made a PR. Apologies for arguably just creating more work for you.

BartmanEH commented 1 year ago

thank you for your continued hard work mining assets!