search

PokeNavBot / issue-tracker

Bug reports / feature tracking repository for PokeNav
https://pokenavbot.com
20 stars 4 forks source link

Ability to toggle off deleting active raids on $end #233

Open Qualibert opened 5 years ago

Qualibert commented 5 years ago

Current behavior: When the $end command is used in a raid channel, it has the "same effect" as deleting it with X / expiring

Issue : If another group want to do the same raid then they either have to re-submit it or work with a cluttered chat with people waiting to get the "raid joined bonus".

Suggested feature : Have a "toggle delete-on-end off" command so that when $end is used in a raid channel it :

A: Give everyone on there the "raid joined bonus" for their profile B: Delete the raid channel, removing the role to members C: Revert the active-raid embed to a "unjoined state" like if "create raid channel immediately" was turned off.

This would also allows raids to stays on the pokenav app for the real time they are available for everyone (tier 1 would be interesting with that feature so people won't get rid of them when they are done soloing them).

Expiring time and deleting with X reaction would work normally.

fortepc commented 5 years ago

Agreed!

TheGerontocracy commented 5 years ago

For me it would be more natural to have a new command, say $done, that does exactly what you want.

angiemjonas commented 5 years ago

I prefer the idea of a new command that will clear everyone who has joined, give them their credit, but allow another group to use the channel until the raid has officially ended. Thank you

benjaminatl commented 5 years ago

Make a new command called “$battle” (preferably like the here so you don’t have to use the command prefix). Have the new command ask to be sure your ready to call battle. Maybe with the $members below the “Are you sure your ready to call battle” message. So you can be sure everyone has arrived.

Once confirmed battle, tag the role with a battle message (similar to how notifications work so it’s easy to see APK), wait 2 minutes then clear the members list, remove role and give credit for the raid.

elprezjs commented 5 years ago

I agree with a $done type command. It would be very useful

angiemjonas commented 5 years ago

I like the idea of a separate command like, "$done" to unjoin the members to have already raided but allow another group to use the channel.

dandesousa commented 4 years ago

@Qualibert since you are the original author of this -- do you still see this as relevant.

To me the safest thing would be $done allows everyone to get credit for the raid when it expires if they already did it. It could also potentially reset the raid room / role back to previous settings.

I do worry that this will rarely be used -- since typically when there are multiple groups ( at least in my experience ) they actually overlap for some period of time, booting people out is kind of annoying to those who are coordinating for the later time.

Qualibert commented 4 years ago

We would use it but it's less relevant for the score since I'm using my own bot for it. So if it's just me, you could pass.

angiemjonas commented 4 years ago

Can it be an individual command? Each person claims 'done' so they can leave and still get credit but leave the room and count open for everyone else.

On Sat, Nov 9, 2019, 10:23 AM Daniel DeSousa notifications@github.com wrote:

@Qualibert https://github.com/Qualibert since you are the original author of this -- do you still see this as relevant.

To me the safest thing would be $done allows everyone to get credit for the raid when it expires if they already did it. It could also potentially reset the raid room / role back to previous settings.

I do worry that this will rarely be used -- since typically when there are multiple groups ( at least in my experience ) they actually overlap for some period of time, booting people out is kind of annoying to those who are coordinating for the later time.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/PokeNavBot/issue-tracker/issues/233?email_source=notifications&email_token=ALAQV22BLMQDFP6NAHUH2M3QS353LA5CNFSM4GFPOWZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUMC7I#issuecomment-552124797, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALAQV2YGV4P2PF3ARFKG3TTQS353LANCNFSM4GFPOWZQ .

dandesousa commented 4 years ago

@angiemjonas thats definite a more reasonable implementation if the main goal is trying to get credit for completed raids, then its possible it can just be a setting for people who leave a raid as well.

What I'm saying is rather than $done, you can just $toggle credit-for-join or something and then users will get credit for the raid after it completes whether they were in the raid or not when it ended. It will remember if they ever joined and there were ever multiple people in it (this would simply involve remembering historical participants).

FlipsCat commented 3 years ago

I am quite confused here..... if two people are in the channel they get credit for raid joined. (regardless the leaderboard is the least important feature rn of Pokenav). but is this incorrect?

I learned today of $p "Please type $bye if done"". you type $go, they type $bye, you host your next lobby?