PokeNavBot / issue-tracker

Bug reports / feature tracking repository for PokeNav
https://pokenavbot.com
20 stars 4 forks source link

Update raid information with latest screenshot. #309

Closed Rhendak closed 4 years ago

Rhendak commented 5 years ago

Is your feature request related to a problem? Please describe. Pokénav doesn't update the timers when a new screenshot of the same raid has been submitted. This causes incorrect timers not to be adjusted when a second screenshot with more accurate information is provided.

Describe the solution you'd like Have the latest screenshot of the same raid update the raid information.

Describe alternatives you've considered None

Additional context Chatlog of 24-02-2018

RhendakToday at 5:12 PM I've asked the user to upload a new screenshot since the first user uploaded the screenshot 20 minutes after it was being taken this making the timers incorrect. I was hoping Pokenav would update the timers on the raid like it always used to do. But it doesn't seem to do this anymore? I noticed this a while back too, thought it was a one time exception then. But it seems to stick around. IVpipsToday at 5:14 PM It does do it Only if the timer wasnt read If its missing it updates RhendakToday at 5:15 PM Can I request it to do it always, in case of incorrect timers? IVpipsToday at 5:16 PM How does PokeNav know the timer is incorrect? RhendakToday at 5:16 PM It doesn't in it's current state, but it could change the timers on based on the latest screenshot of the raid, assuming that's the most correct information SunkastToday at 5:17 PM @IVpips Discord strips all meta data from attachements correct? IVpipsToday at 5:17 PM Yes Its all gone Well all metadata containing that stuff SunkastToday at 5:19 PM Yeah that's what I remembered IVpipsToday at 5:19 PM Times and locations and other custom fields inserted into exif RhendakToday at 5:19 PM The bot could read the local time in the top right corner of the phone and do some math based on that, but I think that that may be some too advanced feature, in terms of usage But all in all, I think it would be safe to assume that the latest screenshot of the same raid would have the most accurate information IVpipsToday at 5:22 PM I dont think that’s necessarily true. It could become a server setting. My reasoning is that some info is usually better than no info but a raid time could have been set correctly or posted late and then manually corrected. Then someone uploads a screenshot after its no more likely to be right than the first. Deduplicatuon was added to prevent rooms from being created twice, not to correct info so usually people double post stuff I worry about the timer being slightly changed by posting a late screenshot So im not opposed to adding the feature but i worry about making the default for that reason I believe that would be a very small change i could add an option for Acceptable compromise? Im also interested in seeing how it works out for you if you engage it RhendakToday at 5:26 PM I would love a server setting for that. It's a great idea. For our instance the first screenshot is more likely to have incorrect information then the second screenshot of the raid. This due new members who have to learn how to use Pokenav and then often end up re-uploading the same screenshot to the correct channels after we explained them the workings of Pokenav (if they first share the screenshot in a wrong channel). The raid then usually tries to be updated by more senior members with a second screenshot IVpipsToday at 5:26 PM So the boss is another thing that isnt corrected unless missing Its more rarely incorrect but want the setting to apply there as well or just timers? Would you mind making a github ticket for this too? RhendakToday at 5:28 PM I've never seen the boss being incorrect, but if it has no negative side effects (to performance) then may as well expand the setting to bosses as well

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been closed due to inactivity.