search

PokeNavBot / issue-tracker

Bug reports / feature tracking repository for PokeNav
https://pokenavbot.com
20 stars 4 forks source link

Add a command to delete a role created by PokeNav #575

Open maconleary opened 3 years ago

maconleary commented 3 years ago

Is your feature request related to a problem? Please describe. I'm responsible for configuring PokeNav for our server, but I am not the server owner. I can create notification roles in the #pokenav channel, but once they are no longer needed, I cannot delete them myself, and have to ask the server owner to do it.

Describe the solution you'd like $delete role rolename should delete a PokeNav-created role of rolename.

TheGerontocracy commented 3 years ago

Even more useful if it also deletes any associated notification-rules.

dandesousa commented 3 years ago

Deleting a role will delete the associated notification rules now -- there actually isn't a way to determine if a role is created by PokeNav without my separately tracking it which I prefer not to actually do.

So are we ok with PokeNav being able to delete any role underneath it?

maconleary commented 3 years ago

Mmm. Probably not, no...

TheGerontocracy commented 3 years ago

Deleting a role will delete the associated notification rules now -- there actually isn't a way to determine if a role is created by PokeNav without my separately tracking it which I prefer not to actually do.

So are we ok with PokeNav being able to delete any role underneath it?

Personally yes, with the possible exception of the team roles, but I'm sure there could be some issues. How about limiting it to roles with notification rules then?

RevisionTwelve commented 3 years ago

There are many other solutions to role removal. If the concern is PokeNav being misused, then admins are welcome to find another tool and misuse that, eg. Dyno's delrole

That said, if the concern is related to removal of non-PokeNav roles, well, folks will do what they do. If they create a role and misname it and want to quickly delete it, now they have to either use discord server tools or a different bot tool. IMO, give them the tools in PokeNav. Supply a warning, like, roles are important. Don't break your server.

FlipsCat commented 3 years ago

The problem is anyone who has access to your Pokenav admin channel could now then delete any role basically in the server by default. Right now I have given access to admins and raid mods and we use it for all our raid moderation updates/settings/ect. This is fine by me bc any setting they can toggle accidentally only affects the raid category and wouldn't actually bother anything else. Easy to fix one category. Hard to fix all of them say someone deleted key roles in the server via Pokenav.

As such I know I would like this to be toggle-able ON or OFF if it were implemented. Otherwise I would have to re-work a lot of other stuff that I really just would rather not.