search

Pokechu22 / Burger

A simple tool for picking out information from the minecraft JARs, primarily useful for developers.
https://b.wiki.vg
MIT License
83 stars 15 forks source link

AttributeError: module 'urllib' has no attribute 'urlretrieve' #10

Closed MSpaceDev closed 5 years ago

MSpaceDev commented 6 years ago

image

When running python3 munch.py --download I get the error seen above. I'm using Python3.7.0.

MSpaceDev commented 6 years ago

I've seemed to fix this error by adding/editing these lines: import urllib.request r = urllib.request.urlretrieve(url, filename=path, reporthook=reporthook)

But now I get a new error further down the line: (From toppings/packets.py) image

Pokechu22 commented 6 years ago

I haven't been actively testing the --download option for a while, since it doesn't work well when doing diffs (and I'm not 100% sure which version it handles). I think there's a chance that it might be downloading an extremely old version of the game and trying to use that, and later parts of burger don't know how to process that. Can you manually download it instead?

MSpaceDev commented 6 years ago

Of course. Didn't realise the --download wasn't being worked on. I'll download it and give it a test.

Alright, I've downloaded the JAR, and it's working like a charm. Thanks for the quick support. Just need the download to be ironed out.

Pokechu22 commented 6 years ago

I've reimplemented the download function (among other things, it now lets you specify a list of versions to download; I think back when it was first implemented there was only a single minecraft.jar URL and the version for it wasn't known ahead of time). This should be fixed on the 1.14-dev branch now; let me know if you still have trouble.