Pokechu22 / Burger

A simple tool for picking out information from the minecraft JARs, primarily useful for developers.
https://b.wiki.vg
MIT License
83 stars 15 forks source link

Update entity tracker newer mc versions #24

Closed u9g closed 3 years ago

u9g commented 3 years ago

not sure if it's just 1.16+ that got this, but in 1.12.2 the old string worked, but in 1.16, the line looks: c.warn("Fetching addPacket for removed entity");, however in 1.17, the line looks like: a.warn("Fetching packet for removed entity {}", this.d);, should I add the line with the {} too? or is it an includes string.includes() comprasion?

Pokechu22 commented 3 years ago

Change looks good to me, will merge.

or is it an includes string.includes() comprasion?

By default, it uses in to check for a match, which is the equivalent to includes. It's possible to force a full string check with (['HORIZONTAL'], True) (and yes, this is gross and confusing syntax, but it does work).