Fixes for 1.20.3 - Githubissues

Pokechu22 / Burger

A simple tool for picking out information from the minecraft JARs, primarily useful for developers.

https://b.wiki.vg

MIT License

83 stars 15 forks source link

Fixes for 1.20.3 #51

Closed mat-1 closed 11 months ago

mat-1 commented 11 months ago

This PR has two fixes:

chatcomponent (aka Component.Serializer) doesn't have any strings since 23w46a, so I changed it to be identified by the field and method signatures, and checking that it doesn't have any constant strings.
Some block/item ids were changed to be defined in references.Blocks and references.Items classes, so I added identifiers for those classes and made it extract the strings from the disassembly.

I tested with 1.14.4, 23w40a, and 1.20.3-pre2.

mat-1 commented 11 months ago

I addressed your review a couple days ago btw, I'm replying to generate a notification in case you didn't see.

Pokechu22 commented 11 months ago

I saw but haven't had time to look into it further yet.

Are you planning on also looking into #49 (either in this PR or in another one)? I have a vague idea of how it could be fixed (once we identify packetbuffer, scan through it to identify all of the functions that just call a single netty function and build a dictionary of those, and then use that when decompiling) but haven't had time to implement it.

mat-1 commented 11 months ago

Are you planning on also looking into #49 (either in this PR or in another one)?

In this PR, no, but I might attempt to fix it later if I find the motivation and energy to. For now I'm just doing the bare minimum to keep my client up-to-date with the latest Minecraft version.