Closed Pokechu22 closed 6 years ago
I didn't make the changes, @Gerrygames did ;)
Oops. Don't know why I thought you did.
In any case, fixed (pokechu22/Hamburglar@169248e). For some reason, I was ignoring changes inside if
and switch
statements -- I think the goal was to ignore the condition which often has obfuscated names, but that seems to not have been what actually happened). Here's what was missed for 1.13:
diff_17w46a_17w47a
: missed PLAY_CLIENTBOUND_43
"Scoreboard Objective", which lost a field.diff_17w47b_17w48a
: missed PLAY_SERVERBOUND_17
"Recipe book data", changed VarInt to identifier. Missed on the wikidiff_17w48a_17w49a
: missed PLAY_CLIENTBOUND_43
"Scoreboard Objective", re-adding the update display name option(?)diff_18w05a_18w06a
: missed PLAY_SERVERBOUND_17
"Recipe Book Data" (serverbound), adding the furnace fieldsdiff_18w19b_18w20a
: missed PLAY_CLIENTBOUND_46
"Teams", re-adding the prefix and suffixI'll be regenerating all the data for this soon; currently it hasn't been regenerated.
After seeing this by @Cybermaxke, something is clearly broken: Hamburger's diff did not show that change, or any packet changes. But weirdly, burger itself did see different packets: 18w19b, 18w20a.
So for the moment, don't trust the packet diffs as exhaustive. I'm not sure why this is happening.