Pokechu22 / Burger

A simple tool for picking out information from the minecraft JARs, primarily useful for developers.
https://b.wiki.vg
MIT License
83 stars 15 forks source link

Hamburglar seems not to be picking up on some changes #7

Closed Pokechu22 closed 6 years ago

Pokechu22 commented 6 years ago

After seeing this by @Cybermaxke, something is clearly broken: Hamburger's diff did not show that change, or any packet changes. But weirdly, burger itself did see different packets: 18w19b, 18w20a.

So for the moment, don't trust the packet diffs as exhaustive. I'm not sure why this is happening.

Cybermaxke commented 6 years ago

I didn't make the changes, @Gerrygames did ;)

Pokechu22 commented 6 years ago

Oops. Don't know why I thought you did.

In any case, fixed (pokechu22/Hamburglar@169248e). For some reason, I was ignoring changes inside if and switch statements -- I think the goal was to ignore the condition which often has obfuscated names, but that seems to not have been what actually happened). Here's what was missed for 1.13:

I'll be regenerating all the data for this soon; currently it hasn't been regenerated.