Pokechu22 / WorldDownloader

Makes a copy of parts of a multiplayer world for singleplayer use (EG, for backups or renders)
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/2520465-world-downloader-mod-create-backups-of-your-builds
Other
567 stars 137 forks source link

I created my own custom DRM using this mod's DRM plugin channel and it is able to crash minecraft. #210

Open JasonTable opened 3 years ago

JasonTable commented 3 years ago

I created a custom DRM plugin using this mod's DRM plugin channel API and it is able to crash the Minecraft client somehow when this mod is active. Unfortunately, I cannot give any further details about this bug because of the proprietary nature of DRM. I created this plugin for the company I work for and I signed an NDA that prohibits me from going into any more detail because it's company trade secrets. However me and my lawyer looked over my NDA contract and he says that this issue post as is it written is not in breach of the contract so I am sharing what I can to try to help make the mod more stable.

Pokechu22 commented 3 years ago

Thank you for reporting this.

Does your crash bug also occur with Minecraft Forge installed (without WDL)? Or is it in something with WDL specifically? (Not to say that you previously tested with WDL+Forge, just that there are some potential crashes that could also affect Forge).

Note that vanilla Minecraft has several network-related crash bugs (which are publicly listed on the bug tracker (though I don't have an example on hand), unlike server-crashing bugs which are kept private), and generally Mojang treats them as lower priority. It's far out of my scope to try vanilla crash bugs, so just being able to crash the client isn't something I'm completely concerned about. But if there's a crash issue that is easy to accidentally run into or something like that, it's definitely worth fixing.

JasonTable commented 3 years ago

what i am allowed to say is that the crash will happen with WDL mod installed but only while its downloading a world.