search

Pokechu22 / WorldDownloader

Makes a copy of parts of a multiplayer world for singleplayer use (EG, for backups or renders)
https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/2520465-world-downloader-mod-create-backups-of-your-builds
Other
572 stars 135 forks source link

update all build.gradles to reflect version change in Forgegradle extensions from 0.0.4 to 0.1.0 #64

Closed Tsoccerguy3 closed 7 years ago

Tsoccerguy3 commented 7 years ago

update build.gradle in all version folders line 27 to reflect version change in Forgegradle extensions from 0.0.4 to 0.1.0

Pokechu22 commented 7 years ago

This doesn't work, at least not yet (from my testing). If I set BEGradle to 0.1.0, then it forces Forgegradle 2.3 instead of 2.2, and for some reason (differences in decompile output?) using the wrong version breaks everything. I will fix this, but it's a bit more complicated than I first thought.

Tsoccerguy3 commented 7 years ago

I see what you mean . Gradlew setupdecompworkspace build failed after I updated . so I changed on 1.10.2 - 1.12 then it compiled .

Tsoccerguy3 commented 7 years ago

you have all minecraft versions on the same mappings snapshot . if I compile say a 1.10.2 or a 1.11.2 against the mappings = 'snapshot_20170617' it will compile , BUT because you fixed all the name to work with the 1.12 there is no menu in 1.10.2 or 1.11.2 .

I fixed the mappings to there correct ones , but the there are naming errors on compile

Minecraft 1.10.x change mappings to stable_29 Minecraft 1.11.x change mappings to stable_32

Pokechu22 commented 7 years ago

Everything should work with that mapping version (at least, it did when I tried it).

I'm still looking for a way to combine older stable mappings with newer snapshot mappings, so that I can use the latest names on older versions (I need the mappings to all match for compatibility, but of course newer mappings don't include older names).

If the menu doesn't appear, that probably means that base patches failed to apply, which can happen when the wrong mapping version is used, since comments can misalign things. It might also happen if you had broken sources due to the wrong ForgeGradle version. The fix is to set first undo any changes to the src/base-patches folders, and then run the applyBasePatches task.

Pokechu22 commented 7 years ago

Oh yea, you may need to run cleanCache task to get everything to build, if you ran with the wrong version.