search

Pokecube-Development / Pokecube-Issues-and-Wiki

This is where all issues for the core pokecube mods should go, also this is where the main wiki should be maintained
MIT License
30 stars 24 forks source link

Crash due to incompatibility between Pokécube and Vampirism/Werewolves mod. #1069

Closed Raeaper closed 2 years ago

Raeaper commented 2 years ago

Issue Description:

Hello good morning, I'm making a ModPack for a group of Streamer friends n it focuses on the Vampirism Mod, Werewolves addon n the majestic Pokécube. But unfortunately it crashes when u start to load the world again.

Vampirism Mod: https://www.curseforge.com/minecraft/mc-mods/vampirism-become-a-vampire

Werewolves Mod: https://www.curseforge.com/minecraft/mc-mods/werewolves-become-a-beast

What happens:

The game apparently crashes due to incompatibility after loading the world the first time, saving n exiting to the title menu n re-entering.

What you expected to happen:

That these unique mods like the Pokécube will not crash n have full compatibility please.

Steps to reproduce:

  1. Start ur world with all 3 mods or just the Pokécube n Vampirism. (It also happens with the Werewolves Mod)
  2. Save n quit to the title menu.
  3. Try to restart the world you left.
  4. Well done the game crashes n error appears in the launcher. ...

https://gist.github.com/Raeaper/352314d4d887857f14be93b743526630

https://gist.github.com/Raeaper/a94d5d1724165516eec7881a637f7c40

Affected Versions (Do not use "latest"): Replace with a list of all mods you have in.

Raeaper commented 2 years ago

Curiously if you try to re-open Minecraft n re-join the crashed world again if it allows it. I just dunno if this corrupts the world or damages it in some way, in any case I don't think it's correct n it seems that at any moment everything will be spoiled.

Thutmose commented 2 years ago

This appears to be something going strange with forge's permissions API, does it happen when you start the world the second time with those other mods as the only mods (ie without pokecube)?

Raeaper commented 2 years ago

with the same mods bro, (Pokécube n Vampirism/Werewolfs) without adding new or other mods. :c

Thutmose commented 2 years ago

I mean does it happen without pokecube?

Raeaper commented 2 years ago

no, it happens with the Pokécube. At the moment I have been testing only with Vampirism and Pokécube together, cause I want to have them as the base of the Modpack. (Pokécube n Vampirsm/Werewolves.)

Thutmose commented 2 years ago

Ok, found the issue and fixes it for next update

Raeaper commented 2 years ago

I can't believe it bro, u're amazing! Really ty very much for ur time to answer and fix it quickly. The best mod for Minecraft <3 and one of the best mod developers. I can't wait for the update to come out. 💯/ 💯

Thutmose commented 2 years ago

It at least fixed the similar issue I had on my end, you will need to test the update to confirm it did actually fix it on yours though

Thutmose commented 2 years ago

you can either get the fixed version from the github release: https://github.com/Pokecube-Development/Pokecube-Issues-and-Wiki/releases/tag/1.19.2-3.19.2 or wait for the curseforge files to be visible (uploaded, but have to go through curseforge's approval system)

Raeaper commented 2 years ago

omg! ty so much bro I will gladly run to test it n I will keep you informed.

P.S.: I want to take the opportunity to tell u that I found other incompatibilities n/or Exploit/Glitches from another Mods, but I will make the respective ticket.

ty so much again.

-Æ.

Raeaper commented 2 years ago

Nope bro still crashing same way.

https://gist.github.com/Raeaper/65f58427d4a8fbd1cf078af8948a7894

Thutmose commented 2 years ago

Hmm odd, it had fixed it in development mode, but apparently not in the deployment environement... I will look into this further

Thutmose commented 2 years ago

what is very odd about the crash, is that it is complaining about the registration of a different mod's permissions....

With pokecube alone, in deployment, it also crashes, but from registration of permissions by MinecraftForge...

Raeaper commented 2 years ago

what do you mean? Will it always crash the second time?

Thutmose commented 2 years ago

ya, and I am trying to look into why, it shouldn't be crashing the first time it loads in though? so this isn't a problem if you don't have to go back to the main menu

Thutmose commented 2 years ago

the very odd thing is that after the fixes I made here: https://github.com/Pokecube-Development/Pokecube-Issues-and-Wiki/commit/af5e86ed8150b3919b8e3bba44f6295281e623f5 the crash stopped happening in develpment mode

Raeaper commented 2 years ago

Okay bro, so sad but thank you very much, I will be on the lookout for news to test it bro.

Thutmose commented 2 years ago

Ya, bugs that only happen after compiling are very annoying to try to fix, as it takes 3-5minutes to compile the mod to test the fixes

Raeaper commented 2 years ago

it is complex but ty so much for trying to fix it bro.

Here I will be waiting for the new update to test it.

Thutmose commented 2 years ago

Let me know if the version here fixes it: https://drive.google.com/file/d/1HXaUOGFZOSucAoW4bMYrQpP1KG6kHf2q/view?usp=sharing

This also appears to fix it on my end.

Raeaper commented 2 years ago

okay, let me check ty.

Raeaper commented 2 years ago

omg! yes bro it's fixed. ty so much

Tested : Alone pokecube-aio-1.19.2-3.19.3 With Vampirism-1.19.2-1.8.1 & Werewolves-1.19.2-1.0.0.0

And I saved and quit to the menu multiple times and without problem.

Raeaper commented 2 years ago

Now I'll check it out with others n keep u updated.

Ty so much again bro

Thutmose commented 2 years ago

Ok, that version will probably be uploaded to curseforge tomorrow then