Pokecube-Development / Pokecube-Issues-and-Wiki

This is where all issues for the core pokecube mods should go, also this is where the main wiki should be maintained
MIT License
30 stars 24 forks source link

(1.18.2) Improperly integrated Modded Biome Spawnlists? #1140

Open fedheadphone opened 1 year ago

fedheadphone commented 1 year ago

Issue Description:

Modded biomes (specifically 'Biomes O' Plenty' and 'Oh The Biomes You'll Go' in this case) do not seem to have proper pokemon spawn lists in 1.18.2.

What happens:

When in seemingly any modded biome, the pokemon spawn list does not have much variance. In my primary modlist, they mainly spawn Scatterbugs. While testing just Pokecube and the previously mentioned biome mods, the Modded biomes didn't have any pokemon spawns listed at all.

What you expected to happen:

More types of pokemon to spawn in modded biomes, like in 1.16.5-3.14.1

Steps to reproduce:

  1. Install Pokecube and 'Biomes O' Plenty'/'Oh The Biomes You'll Go'
  2. Find a Modded Biome that isn't from Pokecube
  3. Check the spawnlists on the Pokewatch to confirm the spawnlist ...

Affected Versions (Do not use "latest"): Replace with a list of all mods you have in.

Thutmose commented 1 year ago

Can you confirm what those biomes are tagged with?

You should be able to see the tags ingame if you use the f3 display, and then hold alt (you may need to change gui scale to 1 to see the list)

Include a screenshot of that in a comment

fedheadphone commented 1 year ago

Here are some screenshots of some affected biomes from my main world, with the F3 + Alt Tags visible.

2023-09-29_12 32 07 2023-09-29_12 32 50 2023-09-29_12 34 35 2023-09-29_12 40 14

And here are some screenshots of affected biomes from a Test world, with only Pokecube, BoP, and ByG.

2023-09-29_13 20 37

2023-09-29_13 21 21

2023-09-29_13 21 39

Thutmose commented 1 year ago

Hmm, some of those are missing the important tags (specifically the is_overworld, and the biome sepecific ones), but others there look like they should work fine.

If you rename an item to spawn_preset_debug, and then right click, does it have any listed in the locations for the first and third images?

The 2nd, 4th and later images use non-standard tags, so they are expected to not work properly, and require a datapack to apply the correct tags to the biomes

fedheadphone commented 1 year ago

The First and Third screenshot's biomes seem to have the exact same spawn preset list.

2023-09-29_20 04 13

2023-09-29_20 08 14

Thutmose commented 1 year ago

Ahh, I see that apparently we do not have many specified for taiga biomes themselves, there should be stantler on the spawn list for those two?

fedheadphone commented 1 year ago

Stantler is not in either spawnlist, according to the pokewatch in my main world. The only listed spawns are: Scatterbug, Cressellia, Darkrai, and Calyrex.

Is there a tutorial to make/template for a datapack that can fix this? I am very inexperienced at this sort of thing.

2023-09-30_16 02 08 2023-09-30_16 02 13