Pokecube-Development / Pokecube-Issues-and-Wiki

This is where all issues for the core pokecube mods should go, also this is where the main wiki should be maintained
MIT License
30 stars 24 forks source link

Trainer Behaviour #311

Open MetaltyrantMk2 opened 4 years ago

MetaltyrantMk2 commented 4 years ago

Issue Description:

Trainers resetting

What happens:

When combatting trainers some are resetting and starting combat instantly again. When this occurs no rewards are delivered to the player for completing the original roster of pokemon.

What you expected to happen:

Combat to occur, rewards given to player, combat cd to come into effect.

Steps to reproduce:

This is difficult to reproduce as there are a lot of different environments that trainers are in this occurs most to the trainers at spawn. This is also quite possible due to dormant areas on the server and the cds not finishing before they go dormant.


Affected Versions: Replace with a list of all mods you have in.

Thutmose commented 4 years ago

if this occurs when the trainer has been attacked, it is intended.

trainers only give rewards if they naturally agress the player trainer cooldowns only apply to the natural agression

Cases where the described behaviour is intentional:

player punches trainer, now trainer is angry and will attack regardless of cooldown, no reward unless it was actually ready to attack (and maybe no reward anyway)

MetaltyrantMk2 commented 4 years ago

If an attack hits a trainer accidentally will this initiate the trainer aggression?

Say the combat move its ranged but the line of sight has the trainer between them.

Thutmose commented 4 years ago

hmm, that might trigger aggression, I can look into that, I can probably blacklist them from the AOE moves if they are configured to not take damage