Pet Interactions - Githubissues

Pokecube-Development / Pokecube-Issues-and-Wiki

This is where all issues for the core pokecube mods should go, also this is where the main wiki should be maintained

MIT License

30 stars 24 forks source link

Pet Interactions #586

Open WenXin20 opened 3 years ago

WenXin20 commented 3 years ago

Issue Description:

With vanilla_pokemobs enabled, pets have issues with interacting.

What happens:

~Pets will not update their sitting state visually, even when pressing the "sit" button.~ Fixed
~Pets cannot be fed/bred.~ Fixed
~Quark allows players to "pet" dogs by shift-right-clicking, but it opens the gui instead.~ Fixed
~Charm adds random dog textures, but the gui doesn't show the current texture.~
~This affects modded pets as well, such as the Hippogryph from Ice and Fire, which I cannot put armor on or feed.~ Fixed

What you expected to happen:

Proper interactions

Steps to reproduce:

Tame a pet
Interact with it. ...

Affected Versions:

Pokecube AIO: v3.6.0.b
Minecraft: v1.16.4
Forge: v35.1.15

Thutmose commented 3 years ago

hmm, any suggestions for how to specify opening pokemob inventory vs accessing them normally? for trainers I made it via right clicking with a pokedex

WenXin20 commented 3 years ago

Right-clicking with a Pokedex sounds best. Or maybe a shift-right-click.

Thutmose commented 3 years ago

hmm, I can look into adjustments so right click with pokedex (but not watch) will apply the interaction for non-standard pokemobs

WenXin20 commented 3 years ago

Alright, that sounds good.

Thutmose commented 3 years ago

that commit should have dealt with this, I can probably have a build out tomorrow or so, if you want to try it earlier, you can probably build it by downloading the repository and running the build.bat, it should make a compiled jar to test with.

The changes make it so that if you right click with a non-standard pokemob, it will do the following:

check for berry use/etc, if so apply those check if holding a pokedex, if so, open gui otherwise do normal interaction

Thutmose commented 3 years ago

Can you update the description for this for which are still a problem? I can probably try to look into the remaining next.

WenXin20 commented 3 years ago

Alright, it's been updated.

WenXin20 commented 3 years ago

I also realized that if a pet is tamed first, then I can't use a pokecube to store/catch it.

Thutmose commented 3 years ago

any links for charm source for how it "adds random dog textures"? the code currently tries to call writeAdditional and readAdditional to sync things like that over...

Thutmose commented 3 years ago

also, when I tamed a cat with fish, it magically found a pokecube to recall into

Thutmose commented 3 years ago

oh, I see, WolfEntity is one of the ones that doesn't support readAdditional on client side

WenXin20 commented 3 years ago

I think this is it: https://github.com/svenhjol/CharmForge/blob/master/src/main/java/svenhjol/charm/client/VariantMobTexturesClient.java

That's strange. I pressed the recall keybind and the pets don't return unless they were caught with a pokeball.

Thutmose commented 3 years ago

how many are fixed here? https://github.com/Pokecube-Development/Pokecube-Issues-and-Wiki/releases/tag/1.16.4-3.6.1

WenXin20 commented 3 years ago

It looks like everything here is fixed. Although I just noticed that when I try to jump while on a horse, it'll jump before I let go of the space bar, so a full powered jump doesn't seem to be possible.

Thutmose commented 3 years ago

ahh right, I need to make a check somehow for "vanilla" control behaviour, and then if that is found, disable the custom stuff.