Pokecube-Development / Pokecube-Issues-and-Wiki

This is where all issues for the core pokecube mods should go, also this is where the main wiki should be maintained
MIT License
30 stars 24 forks source link

Minecolonies NPC trainers bugs. #809

Open Wilevar opened 2 years ago

Wilevar commented 2 years ago

#### Issue Description: After testing with just some UI mods, Pokecube AIO, and Minecolonies, here's the list of features I've found to be working and not working:

#### Working:

#### Not working:


#### Mod List (Using "# ModName" to control load order/organize. 0=Core Mod, 1=UI, 2=Major, 3=Minor, 4=Addons, 5=Fixes)_

0_architectury-1.23.33-forge 0_ftb-library-forge-1605.3.3-build.74 0_structurize-0.13.219-ALPHA-universal 1_appleskin-forge-mc1.16.x-2.1.0 1bwncr-1.16.4-3.9.16 (BadWitherNoCookie)_ 1_Controlling-7.0.0.23 1_Hwyla-forge-1.10.11-B78_1.16.2 1_infinitemusic-1.3.0 1InventoryHud[1.16.2-1.16.5].forge-3.3.0 1_jei-1.16.5-7.7.1.110 1_journeymap-1.16.5-5.7.3 1_JustEnoughResources-1.16.5-0.12.1.121 1_LongerDays-2.0.0-mc1.16.4 1_MouseTweaks-2.14-mc1.16.2 1_WailaHarvestability-mc1.16.x-forge-1.1.15 1_WAWLA-1.16.5-8.0.1 2_minecolonies-1.0.0-RELEASE-universal 2_pokecube-aio-1.16.5-3.13.0 5_FastLeafDecay-v25 5_ftb-backups-2.1.1.6 5_NetherPortalFix_1.16.3-7.2.1 5_performant-1.16.2-5-3.72m 5_polymorph-forge-1.16.5-0.25 5_randompatches-2.4.4-forge 5_shutupexperimentalsettings-1.0.3 5_smoothboot-forge-1.16.4-1.2.2 5_swingthroughgrass-1.16.4-1.5.3 OptiFine_1.16.5_HD_U_G8 OptiForge-MC1.16.5-0.5.7

Thutmose commented 2 years ago

On:

1) Wild Pokemon don't agro citizens. 2) Citizens "see" pokemon and look at them, but never initiate combat or attempt to capture them. 3) Citizens don't use their pokemon when attacked by monsters or the player. 4) Making a pokemon via the NPC Edit screen, then taking that pokemon from a citizen (via the pokedex) and sending out that pokemon either makes the game freeze, no crash report generated, or the pokemon disappears immediately after the pokecube hits the ground. 5) Citizens with pokemon might fight with the player, but only if the player attacks them with their own pokemon, and not consistently. It happened for me once, but other times the citizens just fled.

2, 3 and 4 will need some looking into, I did make some AI related adjustments yesterday when I found some things a bit odd about the villager-trainers, it may help with the minecolonies ones

1) is not currently supposed to occur anyway, wild pokemobs are currently only set to agro other pokemobs or players, I can see about trying to do some config related stuff to add other targets to their lists though. 5) Currently agroing players is only enabled for the stock trainer npcs, I can also see about making a config option to enable this on others.

Wilevar commented 2 years ago

Understood! Thanks for the consideration. Granted, none of it is by any means required. Completely at your leisure/willingness. If it's too much hassle and you decide not to support Minecolonies compatibility, I'd understand and only suggest editing the Curseforge page info about it.

That said, if you do manage to get it working with their NPCs, that'll make some very interesting town building. ^_^

Unrelated, I'm strongly considering trying to take a crash-course on minecraft modding through Forge, and possibly take up the Poke-player upkeep. Been thinking about expanding the concept into some more mystery-dungeon-like features, with pokemon acting as villagers themselves when interacting with a player that's a pokemon.

Wilevar commented 2 years ago

In regard to the minecolonies testing with the 3.13.1.a build:

I managed to catch a few rattatta and bidoof, give them to unemployed citizens, and witness them throwing pokeballs at some wild pokemon that happened to attack them while fighting amongst themselves.

Those that were caught show up in their trainer inventory, but any that sustained damage prior to being caught don't appear to be healing in the citizen's inventory. They use the pokemon to defend against monsters, so I can assume that they'll do the same against other pokemon.

Wild pokemon don't attack them of course, so other than monster (if enabled) and minecolony raiders, they won't have a reason to fight, but they are sending out their pokemon when attacked.