search

PokemonGoF / PokemonGo-Bot-Backup

The Pokemon Go Bot, baking with community.
http://maps.pikabot.org
MIT License
109 stars 15 forks source link

Capitalized pokemon names in config example to avoid confusion #20

Closed javajohnHub closed 8 years ago

DBa2016 commented 8 years ago

You can provide evolve_list /do_not_evolve_list as either a string (comma-separated Pokemon names, like "dratini, dragonair") or as a list like ["dratini", "dragonair"]. While the first form is turned to lowercase during config parsing in evolve_pokemon.py (-> https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/pokemongo_bot/cell_workers/evolve_pokemon.py#L45, https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/pokemongo_bot/cell_workers/evolve_pokemon.py#L48), this lowercasing does not happen if the parameter is provided as a list to begin with.

Since the values are then compared to lowercased Pokemon names (https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/pokemongo_bot/cell_workers/evolve_pokemon.py#L140, https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/pokemongo_bot/cell_workers/evolve_pokemon.py#L142), the comparisons will be always "false" if provided in upper case.

I suggest you either convert everything to lowercase during comparison or at least do not encourage people to use uppercase here.

javajohnHub commented 8 years ago

Thank you. I was unaware of the [dratini, drowzee] syntax