smfbrooks commented 8 years ago

Expected Behavior

If the EvolvePokemon task is placed before TransferPokemon and pokemon in inventory that matches EvolvePokemon criteria, it should be evolved and not released.

Actual Behavior

Caught pokemon are being released based on TransferPokemon criteria before checking EvolvePokemon task.

[02:32:02] Used Pokeball, with chance 46.83 (93 left)
[02:32:02] Captured Zubat! [CP 358] [Potential 0.47] [8/12/1] [+160 exp]
[02:32:02] You now have 353 Zubat candy!
[02:32:08] Moving towards Jigglypuff, 0.11km, left (4 minutes, 35 seconds)
[02:32:08] {'distance_unit': '', 'distance': '', 'current_position': (34.012686475473366, -118.49430835549778), 'last_position': (34.01261643439484, -118.4944613552471)}
[02:32:10] Releasing Zubat [CP 358] [IV 0.47] based on rule: CP < 386 OR IV < 0.8
[02:32:10] Exchanged Zubat [CP 358] [IV 0.47] for candy.

[02:39:41] Something rustles nearby!
[02:39:42] A wild Ekans appeared! [CP 456] [Potential 0.11] [A/D/S 1/2/2]
[02:39:46] Used Pokeball, with chance 29.94 (91 left)
[02:39:46] Captured Ekans! [CP 456] [Potential 0.11] [1/2/2] [+120 exp]
[02:39:46] You now have 343 Ekans candy!
[02:39:52] Moving towards Graveler, 0.12km, left (6 minutes, 18 seconds)
[02:39:52] {'distance_unit': '', 'distance': '', 'current_position': (34.01621040331073, -118.4964659031602), 'last_position': (34.01634860285054, -118.49651519441859)}
[02:39:54] Releasing Ekans [CP 456] [IV 0.11] based on rule: CP < 494 OR IV < 0.8
[02:39:54] Exchanged Ekans [CP 456] [IV 0.11] for candy.

Your config.json (remove your credentials and any other private info)

http://hastebin.com/verogehiho.php

Steps to Reproduce

Use above config task ordering.

Other Information

OS: Windows 10 Git Commit: 9ae1b785f0836d8769d011626d2bc071ed338bff Python Version: 2.7.12

RedViper9 commented 8 years ago

Please check to make sure you have sufficient candy for evolve.

Here's one of my bots on the most recent Dev pull:

[00:15:35] A wild Dodrio appeared! [CP 839] [Potential 0.33] [A/D/S 9/6/0]
[00:15:38] Catch rate of 14.12 with Pokeball is low. Throwing Razz Berry (have 98)
[00:15:38] Threw a Razz Berry! Catch rate with Pokeball is now: 21.17
[00:15:39] Used Greatball, with chance 30.61 (49 left)
[00:15:40] Captured Dodrio! [CP 839] [Potential 0.33] [9/6/0] [+160 exp]
[00:15:40] You now have 49 Doduo candy!
[00:15:45] Keeping best 2 Dodrio, based on cp and iv
[00:15:46] Exchanged Dodrio [CP 839] [IV 0.33] for candy.
[00:15:50] Successfully evolved Doduo with CP 469 and IV 0.87!

smfbrooks commented 8 years ago

@RedViper9 I have added 2 cases that I have described.

focamonca commented 8 years ago

follow

smfbrooks commented 8 years ago

Issue persists in 350148e8443e35a6f5b74169b7ac5fd26815fe7b

bzuilhof commented 8 years ago

"evolve_above_cp": 9999, Isnt this line in your config the problem?

thellimist commented 8 years ago

https://github.com/PokemonGoF/PokemonGo-Bot/issues/3416

Use Fizcko's config file

smfbrooks commented 8 years ago

@thellimist I changed the config based on your recommendation:

      {
        "type": "TransferPokemon"
      },
      {
        "type": "EvolvePokemon",
        "config": {
            "evolve_all": "Ekans,Zubat,Venonat,Spearow,Doduo",
            "first_evolve_by": "iv",
            "evolve_above_cp": 0,
            "evolve_above_iv": 0,
            "logic": "or",
            "evolve_speed": 20,
            "use_lucky_egg": false
        }
      },

Here is the result (no change):

[04:40:11] A wild Ekans appeared! [CP 520] [Potential 0.53] [A/D/S 0/15/9]
[04:40:13] Catch rate of 29.36 with Pokeball is low. Throwing Razz Berry (have 2)
[04:40:13] Threw a Razz Berry! Catch rate with Pokeball is now: 44.04
[04:40:14] Used Pokeball, with chance 44.04 (102 left)
[04:40:14] Ekans capture failed.. trying again!
[04:40:15] Used Pokeball, with chance 44.04 (101 left)
[04:40:16] Captured Ekans! [CP 520] [Potential 0.53] [0/15/9] [+210 exp]
[04:40:16] You now have 403 Ekans candy!
[04:40:22] Moving towards Arcanine, 0.15km, left (10 minutes, 36 seconds)
[04:40:22] {'distance_unit': '', 'distance': '', 'current_position': (34.01583977929111, -118.49623902350463), 'last_position': (34.01592163925327, -118.49638441978935)}
[04:40:23] Releasing Ekans [CP 520] [IV 0.53] based on rule: CP < 494 OR IV < 0.8
[04:40:23] Exchanged Ekans [CP 520] [IV 0.53] for candy.
[04:40:27] Something rustles nearby!
[04:40:27] A wild Ekans appeared! [CP 449] [Potential 0.24] [A/D/S 1/8/2]
[04:40:31] Catch rate of 30.56 with Pokeball is low. Throwing Razz Berry (have 1)
[04:40:31] Threw a Razz Berry! Catch rate with Pokeball is now: 45.84
[04:40:31] Used Pokeball, with chance 45.84 (100 left)
[04:40:31] Captured Ekans! [CP 449] [Potential 0.24] [1/8/2] [+210 exp]
[04:40:31] You now have 407 Ekans candy!
[04:40:37] Releasing Ekans [CP 449] [IV 0.24] based on rule: CP < 494 OR IV < 0.8
[04:40:37] Exchanged Ekans [CP 449] [IV 0.24] for candy.

[04:43:20] A wild Zubat appeared! [CP 344] [Potential 0.33] [A/D/S 6/5/4]
[04:43:23] Used Greatball, with chance 42.96 (0 left)
[04:43:23] Captured Zubat! [CP 344] [Potential 0.33] [6/5/4] [+210 exp]
[04:43:23] You now have 465 Zubat candy!
[04:43:29] Moving towards Meowth, 0.18km, left (6 minutes, 51 seconds)
[04:43:29] {'distance_unit': '', 'distance': '', 'current_position': (34.01618711866749, -118.49738132487884), 'last_position': (34.01614551999619, -118.49725376224688)}
[04:43:31] Releasing Zubat [CP 344] [IV 0.33] based on rule: CP < 386 OR IV < 0.8
[04:43:31] Exchanged Zubat [CP 344] [IV 0.33] for candy.
[04:43:35] Moving towards Meowth, 0.17km, left (6 minutes

thellimist commented 8 years ago

@keugnu You forgot the

"evolve_captured": "Pidgey,Weedle,Caterpie,Rattata,Zubat,Drowzee,Diglett,Doduo,Sandshrew,Ekans,Spearow,Poliwag,Oddish,Nidoran M,Nidoran F,Staryu,Goldeen,Horsea,Rhyhorn,Cubone,Voltorb,Krabby,Magnemite,Kabuto,Psyduck,Meowth,Venonat,Jigglypuff,Clefairy,Mankey,Tentacool,Paras,Shellder,Seel,Omanyte",

setting.

{
"auth_service": "???",
"username": "???",
...
"tasks": [
...
},
{
"type": "TransferPokemon"
},
{
"type": "EvolvePokemon",
"config": {
"evolve_all": "none",
"first_evolve_by": "iv",
"evolve_above_cp": 0,
"evolve_cp_min": 0,
"logic": "and",
"evolve_speed": 20,
"use_lucky_egg": false
}
},
[...]
],
"websocket_server": false,
"walk": 7.16,
"action_wait_min": 1,
"evolve_captured": "Pidgey,Rattata,Zubat,Spearow,Weedle,Kakuna,Caterpie", 
...
[...]
}

smfbrooks commented 8 years ago

@thellimist Yes, I see your edit, however this option is very likely to be removed. #3530 The issue is mainly that is seems the EvolvePokemon task is being ignored, or pokemon_catch_worker.py is calling TransferPokemon, but I did not see it explicitly.

RedViper9 commented 8 years ago

@keugnu Gah. My bad. In your new config above, you have Transfer before EvolvePokemon. Try switching the order.

Yes it should evolve any pokes you have in your bag, but it seems to be skipping...

sanchez0506 commented 8 years ago

just use git reset --hard 651c909

smfbrooks commented 8 years ago

Issue persists in 543226e81b864d0fd714337e7cce1da8ac0a0005

belinux commented 8 years ago

Same here..

smfbrooks commented 8 years ago

I have figured out a temporary workaround for this task ordering problem. Applying never_release: true to the release config is working, however, this should be reverted once you run out of candy for the evolutions. Keep in mind that is does not solve the issue.