search

PokemonGoF / PokemonGo-Bot

The Pokemon Go Bot, baking with community.
MIT License
3.87k stars 1.54k forks source link

Sniper Catching Pokemon I haven't stated? #5714

Open BarrieG14 opened 8 years ago

BarrieG14 commented 8 years ago

Expected Behavior

To only catch "Arcanine": 800, "Charizard": 800, "Venusaur": 600, "Lapras": 600, "Dragonite": 600, "Gyarados": 600, "Snorlax": 600

Actual Behavior

Teleporting to loads of pokemon not in list^

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/4qUnMFeQ

Output when issue occurred

[2016-09-27 13:12:25] [ Sniper] [INFO] Teleporting to meet Tangela (40.76204; -73.984335)... [2016-09-27 13:12:29] [ Sniper] [INFO] Yay! There really is a wild Tangela nearby! [2016-09-27 13:12:30] [ Sniper] [INFO] Teleporting back to the old position (51.4984578703; -0.125842563395)... [2016-09-27 13:12:33] [PokemonCatchWorker] [INFO] A wild Tangela appeared! (CP: 474) (NCP: 0.27) (Potential 0.71) (A/D/S 13/7/12) [2016-09-27 13:12:36] [PokemonCatchWorker] [INFO] This is a VIP pokemon. Catch!!! [2016-09-27 13:12:39] [PokemonCatchWorker] [INFO] Threw a Razz Berry! Catch rate with Pokeball is now: 56.80 [2016-09-27 13:12:45] [PokemonCatchWorker] [INFO] OK Curveball throw! Used Ultraball, with chance 92.10 (10 left) [2016-09-27 13:12:45] [PokemonCatchWorker] [INFO] Captured Tangela! [CP 474] [NCP 0.27] [Potential 0.71] 13/7/12 [+610 exp] [+100 stardust] [2016-09-27 13:12:45] [PokemonCatchWorker] [INFO] You now have 3 Tangela candy! [2016-09-27 13:13:06] [MoveToFort] [INFO] Moving towards pokestop Richard I - The Lionheart - 0.05km [2016-09-27 13:13:08] [UpdateLiveStats] [INFO] Level 25 | Uptime : 0:03:44 | Earned 400 Stardust | +1,630 XP | 26,147 XP/h | Visited 1 stops [2016-09-27 13:13:08] [ShowBestPokemon] [INFO] Best Pokemons (Gyarados, CP 1949, IVCP 0.97, DPS 10.21, HP 138/138) | (Hypno, CP 1371, IVCP 0.45, DPS 11.27, HP 115/115) | (Flareon, CP 1338, IVCP 0.53, DPS 12.72, HP 80/80) | (Hypno, CP 1312, IVCP 0.71, DPS 12.26, HP 115/115) | (Hypno, CP 1304, IVCP 0.41, DPS 11.93, HP 115/115) [2016-09-27 13:13:13] [ Sniper] [INFO] Teleporting to meet Parasect (22.373733; 114.118713)... [2016-09-27 13:13:17] [ Sniper] [INFO] Yay! There really is a wild Parasect nearby! [2016-09-27 13:13:17] [ Sniper] [INFO] Teleporting back to the old position (51.4984870811; -0.125843203669)... [2016-09-27 13:13:20] [PokemonCatchWorker] [INFO] A wild Parasect appeared! (CP: 167) (NCP: 0.1) (Potential 0.6) (A/D/S 2/10/15)### Steps to Reproduce

Run the bot

Other Information

OS: OSX El Capitan 10.11.2 Branch:

Git Commit: fd495448 Python Version: Python 2.7.12
YvesHenri commented 8 years ago

Hi @BarrieG14, thanks for your report. By analyzing your config, it looks like it's indeed a bug. Can you please enable it's debug (place a "debug: true" after the "enabled" param)? That'll help us.

BarrieG14 commented 8 years ago

So where it says:

"type": "Sniper", "config": { "enabled": debug:true, "mode": "url",

Is that what you meant?

ariefbayu commented 8 years ago

I think, this is what @YvesHenri meant:

"type": "Sniper",
"config": {
"enabled": true,
"debug":true,
"mode": "url",
BarrieG14 commented 8 years ago

Thanks ariefbayu.

YvesHenri commented 8 years ago 
"type": "Sniper",
"config": {
"enabled": true,
"debug": true,
"mode": "url",
...

Post new logs again, afterwards.

BarrieG14 commented 8 years ago

2016-09-27 14:45:15] [ Sniper] [INFO] Fetching pokemons from the sources... [2016-09-27 14:45:15] [ Sniper] [INFO] Source 'http://pokesnipers.com/api/v1/pokemon.json' returned 18 results [2016-09-27 14:45:21] [ Sniper] [INFO] Source 'https://pokewatchers.com/grab/' returned 57 results [2016-09-27 14:45:21] [ Sniper] [INFO] After merging, we've got 65 results [2016-09-27 14:45:21] [ Sniper] [INFO] Kangaskhan is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Snorlax is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Dragonair is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Hitmonlee is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Dratini is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Kangaskhan is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Rapidash is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Aerodactyl is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Jynx is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Dragonite is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Haunter is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Poliwrath is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Dratini is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Pidgeot is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Jynx is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Electrode is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Haunter is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Vaporeon is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Electrode is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Dewgong is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Farfetchd is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Electabuzz is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Venusaur is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Nidoqueen is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Farfetchd is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Kabuto is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Farfetchd is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] MrMime is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Farfetchd is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Tangela is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Dragonair is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Hitmonlee is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Butterfree is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Tentacruel is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Nidoqueen is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Porygon is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] MrMime is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Wigglytuff is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Haunter is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Nidoqueen is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Rapidash is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Farfetchd is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Weepinbell is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Vaporeon is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Hypno is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Kangaskhan is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Hitmonchan is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Pinsir is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Nidoking is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Marowak is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Aerodactyl is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Onix is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] MrMime is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Primeape is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Scyther is not catchable, nor a VIP or a missing one and bad IV (if any). Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Blastoise is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Electrode is expired! Skipping... [2016-09-27 14:45:21] [ Sniper] [INFO] Poliwrath is not catchable, not VIP and bad IV (if any), however its a missing one. [2016-09-27 14:45:21] [ Sniper] [INFO] Teleporting to meet Poliwrath (40.757979; -73.979652)... ^C[2016-09-27 14:45:25] [PokemonGoBot] [INFO] Bot caught SIGINT. Shutting down.

BarrieG14 commented 8 years ago

Still trying to catch Poliwrath??

BarrieG14 commented 8 years ago

But then it [2016-09-27 14:45:21] [ Sniper] [INFO] Teleporting to meet Poliwrath (40.757979; -73.979652)...

YvesHenri commented 8 years ago

It classfied Poliwrath as a missing one: [2016-09-27 14:45:21] [ Sniper] [INFO] Poliwrath is not catchable, not VIP and bad IV (if any), however its a missing one. Have you really caught one before? Also, post your config again, please.

BarrieG14 commented 8 years ago

http://pastebin.com/zEJ0pjks

BarrieG14 commented 8 years ago

But I have not got it set to catch missing have I? Only "order": ["priority"],

YvesHenri commented 8 years ago

Exactly. You did not. However, we can see that there's no other valid pokemon to snipe, except the ones you haven't caught. I'll decide what to do in such situations. What's your opinion about this?

BarrieG14 commented 8 years ago

So it will just catch the ones that I have not caught in that situation? So what does the list below it saying:

"catch": { "Arcanine": 800, "Charizard": 800, "Venusaur": 600, "Lapras": 600, "Dragonite": 600, "Gyarados": 600, "Snorlax": 600

Am I wrong in thinking that it would only look for these? As that is what I would like it do. Or have I missed something somewhere?

GhosterBot commented 8 years ago

@BarrieG14. All Pokemons from the source https://pokewatchers.com/grab/ are wrongly tagged as Expired (as seen in your log). That's because there is a mistake in the example config file. On the "url": "https://pokewatchers.com/grab/", bloc of the Sniper task, replace "milliseconds" by "seconds" on the expiration parameters, like this

                    "expiration": { "param": "timeend", "format": "seconds" }

That way you'll have more potential Pokemon to Snipe

YvesHenri commented 8 years ago

@BarrieG14 I know exactly what you mean. Not specifing the missing ordering does not mean it will not snipe them (not until now). It's just an ordering, since some people might want to snipe missing ones instead of those in the catch/vip list. I do agree that this might sound confusing and I'll think what to do in such situations in order to submit a fix (@Gobberwart see this).

@GhosterBot That's not a mistake since it was working fine a few days ago. They might have changed it and I'll fix the config anyways. Good catch.

BarrieG14 commented 8 years ago

So will it not just only catch what I have asked it to under "catch": { ?

GhosterBot commented 8 years ago

@YvesHenri . Yup ;-) (I was fighting this issue since 5 days at least, see https://github.com/PokemonGoF/PokemonGo-Bot/pull/5634 )

About @BarrieG14 question. The same situation will came with VIP or excellent IV found. Most elegant solution is to keep Pokemon related to the order parameter only. So if you specify "priority" only, it will not Snipe missing, VIP or Excellent IV Pokemon not on the catch list.

Or we need another parameter...

YvesHenri commented 8 years ago

@GhosterBot No more parameters! The initial purpose of the ordering was to ONLY order by it. Missing pokemons can be the only one that I'll open an exception, since VIPS should always be caught and the good IV ones have their special param for that (special_iv).

Gobberwart commented 8 years ago

Sorry, fat fingers. Didn't mean to close this.

trippyhat commented 7 years ago

The sniper config is a bit confusing. I am also encountering the situation where pokemons not stated in the sniper catch list are being caught. I think the natural understanding is that when we have the sniper turned on, we only want to catch what is in the sniper catch list, not in the vip or elsewhere.

The current setup complicates the scenario where say, we want to only snipe lapras, but I have vaporeon and jolteon in the vip list (so that I can use candies when catching the vip ones). Either I have to delete the vip list so that the sniper won't teleport to catch those two pokemons and then lose the ability to use berries on them, or I have to accept that the bot teleports to pokemon that I don't want to snipe.

We could also list out the entire pokemon list in the sniper list, and set the ones we don't want to have priority 0, but that's really just too much work if all we want to do is snipe a few pokemons. I don't think any of us wants to list out 200+ pokemons with priority 0 just to do this.

Can the logic be changed so that the sniper only catches the pokemons that we defined in the sniper catch list? It can still continue to walk around and bot, and obey the release rules.

xty commented 7 years ago

It has been 5 months since the issue was filed, yet it seems the problem did not go away when I logged in today with the mode of sniper set to "social" – it catches random Pokémon that are neither uncaught, in my catch list, nor considered as VIPs under my specified rules. Has anyone found a workaround?

xty commented 7 years ago

Output when issue occurred

[2017-02-24 05:49:46] [    Sniper] [INFO] Dragonite is expired! Skipping...
[2017-02-24 05:49:46] [    Sniper] [INFO] Clefairy is not catchable, but has a decent IV!
[2017-02-24 05:49:46] [    Sniper] [INFO] Sniping the 1 best Pokemons found, ordered by [u'priority', u'vip', u'missing']
[2017-02-24 05:49:46] [    Sniper] [INFO] +----+------+----------------+-------+----------+---------+---------+----------+
[2017-02-24 05:49:46] [    Sniper] [INFO] |  # |   Id | Name           |    IV | Verified | VIP     | Missing | Priority |
[2017-02-24 05:49:46] [    Sniper] [INFO] +----+------+----------------+-------+----------+---------+---------+----------+
[2017-02-24 05:49:46] [    Sniper] [INFO] |  1 |   35 | Clefairy       |   100 | None     | False   | False   |        0 |
[2017-02-24 05:49:46] [    Sniper] [INFO] +----+------+----------------+-------+----------+---------+---------+----------+
[2017-02-24 05:49:46] [    Sniper] [INFO] Clefairy is not catchable, but has a decent IV!
[2017-02-24 05:49:46] [    Sniper] [INFO] Teleporting to meet Clefairy (40.8021071847; -73.9600908997)...
[2017-02-24 05:49:49] [    Sniper] [INFO] Yay! There really is a wild Clefairy nearby!
[2017-02-24 05:49:50] [    Sniper] [INFO] Teleporting back to the old position (1.30663994261; 103.832826989)...
[2017-02-24 05:49:53] [PokemonCatchWorker] [INFO] A wild Clefairy appeared! (CP: 762 IV: 0.58 A/D/S 11/0/15 NCP: 0.7)
[2017-02-24 05:50:04] [PokemonCatchWorker] [INFO] Nice throw! Used Greatball, with chance 35.48 (2 left)
[2017-02-24 05:50:05] [PokemonCatchWorker] [INFO] Clefairy capture failed.. trying again!
[2017-02-24 05:50:20] [PokemonCatchWorker] [INFO] Great throw! Used Greatball, with chance 35.48 (1 left)
[2017-02-24 05:50:21] [PokemonCatchWorker] [INFO] Clefairy capture failed.. trying again!
[2017-02-24 05:50:30] [PokemonCatchWorker] [INFO] Great Curveball throw! Used Greatball, with chance 35.48 (0 left)
[2017-02-24 05:50:31] [PokemonCatchWorker] [INFO] Captured Clefairy! (CP: 762 IV: 0.58 11/0/15 NCP: 0.7) Catch Limit: (149/800) +160 exp +100 stardust
[2017-02-24 05:50:31] [PokemonCatchWorker] [INFO] You now have 402 Clefairy candy!

It is as through the bot thinks the Clefairy has perfect IVs whereas in reality its IVs are 11/0/15 only…