PokemonGoF / PokemonGo-Bot

The Pokemon Go Bot, baking with community.
MIT License
3.87k stars 1.54k forks source link

Not catching any pokemons #821

Closed sffetlio closed 8 years ago

sffetlio commented 8 years ago

Since I updated to dev, the bot is not catching any pokemons. The log shows 20+ pokestops and no pokemons between them.

"mode": "all" in the config

Other Information

OS: Ubuntu fa9df3b05072432f3ca1f9d68a39cf086a4686eb

alvarogzp commented 8 years ago

same here, only catches pokemons at the beginning, then it starts going to pokestops and forgets about pokemons

raskyer commented 8 years ago

This is a critical bug that we are trying to fix at the moment ... Not sure it will be fix in the next hours.

If you got a commit version, branch or tagged that work please refer the name here, like that we can try to move quickly.

Thanks :)

sffetlio commented 8 years ago

I have 6e99169d963bd8637dfb55426650f2fe15e694bd and it's working there.

tstumm commented 8 years ago

Does the problem still persist when using "poke" as farming mode?

gpires commented 8 years ago

@tstumm: "poke" works, but "all" doesn't.

Commit: 32cefeed4760d6b5d2b3eb76d783d0f13d068e83

Edit: I think its fixed on: 33a0ad6c6645415e7491b1d76fe664f40376fb16

josephmcox commented 8 years ago

Yes everything is working if you do a new pull down fresh and run all the install instructions. It does seem to prioritize pokestops now instead of pokemon. I am still not capturing many pokemon...

z4ppy commented 8 years ago

Same here, last version (33a0ad6) and no capturing pokemon with "all".

josephmcox commented 8 years ago

Even in mode poke not much is being caught. Could this be an issue with the new google directions commit? Last night before updating I was in the same area and was catching a ton of stuff

josephmcox commented 8 years ago

Confirmed if i checkout 335a0aa9a6e57fef17d0865b2f404e0ca785124b it is catching pokemon as normal. So something after that is causing this.

momonjo commented 8 years ago

@josephmcox but on https://github.com/PokemonGoF/PokemonGo-Bot/commit/335a0aa9a6e57fef17d0865b2f404e0ca785124b335a0aa , it has teleportation problem...

josephmcox commented 8 years ago

Ahh didnt know that. I have been using it and not getting banned.... its been working great.. lol as soon as you said that I got a warning in console about a softban. edit- maybe not softban I think inventory was full so it wasnt letting me spin

leadboots5 commented 8 years ago

broken as of https://github.com/PokemonGoF/PokemonGo-Bot/pull/735 to help narrow it down to 7 or so builds

bstpierr commented 8 years ago

I tried checking out 335a0aa and got softbanned after a few minutes due to teleporting between stops.

I've switched to using the master branch until this is resolved.

josephmcox commented 8 years ago

Does master branch work for catching at a decent speed?

bstpierr commented 8 years ago

It still seems to not see as many mons as I would expect, but at least it finds something between stops once in a while.

In my current session it caught 5 Pokemons in the last 10 minutes, between 8 Pokestops.... and it caught one more as I wrote this, so maybe it's not so bad after all :)

Foulwerp commented 8 years ago

Master works correctly, catching is only broken on dev.

bstpierr commented 8 years ago

Master does seem to have some strange pathing between stops though. I'm not sure why that southernmost stop was so appealing.

screen shot 2016-07-25 at 3 19 47 pm
josephmcox commented 8 years ago

How did you get that map?

rguedes commented 8 years ago

@josephmcox run this command on root folder: git submodule foreach git pull origin master

thanhtran0302 commented 8 years ago

@josephmcox https://github.com/OpenPoGo/OpenPoGoWeb

IcicleTF commented 8 years ago

Yeah, same issue. Even when setting it to "poke" mode instead of "all" or "farm", it will catch a pokemon or two and then perpetually go between certain Pokestops.

bstpierr commented 8 years ago

Is anyone looking into this? I feel as though all development is blocked on the dev branch until this can be resolved.

dddbliss commented 8 years ago

Issue appears to be part of the Stepper refactor. Appears that map cells are not refreshed, so new catchable pokemon are not seen. I am fiddling with it, but python is new to me.

Revision 586a0dc

bstpierr commented 8 years ago

I think the biggest issue is the fort loop here: https://github.com/PokemonGoF/PokemonGo-Bot/blob/4555466/pokemongo_bot/__init__.py#L206

This won't break out until all the forts in a cell have been visited, or the bot encounters a stop it couldn't spin.

This is wrong for a few reasons. Most obviously, it prevents the PokemonCatchWorker from acting for a long time. It also means that the bot will artificially move with a cell more than it should. The nearest stop may actually be closer, but in a neighboring cell. This second point may be the root cause of https://github.com/PokemonGoF/PokemonGo-Bot/issues/830 Furthermore, this loop is essentially another navigator that hijacked the navigation from SpiralNavigator.

I believe this is a symptom of the current design (or at the very least, the partial refactor of the new design). Are workers expected to call other workers during their work, or should they periodically pause their work to allow others to act? Without a well-defined protocol between the two, bugs like this will continue to appear.

krypttr commented 8 years ago

Still not resolved. Bot roams between forts and no pokemon in sight.

bstpierr commented 8 years ago

The PR hasn't been merged. It's not expected to be working until it is.

That's why I cherry-picked it into my own branch in the meantime :)

rlking commented 8 years ago

git fetch https://github.com/binarydepartment/PokemonGo-Bot.git bugfix/catch-pokemon git cherry-pick 79165fad5bff7ae29a229283fdaaa23d217e2c27

but you need to resolve the conflicts

krypttr commented 8 years ago

Thank you @rlking. But, I'm pretty new to git and have no idea on how to "resolve the conflicts". However, I'll try.

AdaptCharm commented 8 years ago

Please upgrade to the latest dev branch by running this command:

git reset --hard
git pull -f

Then run this command: pip install --upgrade -r requirements.txt

If issue persists, open a new issue.

/closed