search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Pokemons not in order in pokedex page #104

Closed mfkaptan closed 8 years ago

mfkaptan commented 8 years ago

Some pokemons are in the wrong place on the pokedex index page. Some of them are: 19 Ratata, 129 Magikarp, 132 Ditto

image

AlexanderLill commented 8 years ago

This is because the pokemon are not sorted by the @PokemonGoers/pokedata team, meaning the call to api/pokemon returns the pokemon 1, 2, 3, 132, 4, ... etc.

I think it would make the most sense if we sort them client-side - what do you guys think? @PokemonGoers/catch-em-all

This looks like a valid solution: http://stackoverflow.com/questions/32882013/angular-2-sort-and-filter

WoH commented 8 years ago

I have just briefly looked at stackoverflow, but a sorting pipe (orderById) is the way to go here. Angular 2 doesn't ship with one, but the complexity is very low.

swathi-ssunder commented 8 years ago

This is now fixed and the API returns the Pokemons in ascending order of pokemon ids. Someone could close this issue as I do not have access.

WoH commented 8 years ago

Guess that works aswell :smile:

AlexanderLill commented 8 years ago

@swathi-ssunder thanks :)