search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Rename poke-filter-popover, extract template (still inline thanks to … #111

Closed MajorBreakfast closed 7 years ago

MajorBreakfast commented 7 years ago

…webpack)

mfkaptan commented 7 years ago

Looks good to me

MajorBreakfast commented 7 years ago

I'm merging this now.

@WoH To address your concern: My response was "The tag name/selector should mirror the class name. Tags cannot be scoped so prefixing them makes sense". I'm merging this due to there being a lot of classes in the project that are named my way. Nevertheless I can be swayed on that. But then we should consistently rename all of them. I won't do that myself because I like the names how they are right now. So feel free to rename them as you feel fit.

WoH commented 7 years ago

I am requesting changes for good reason.

MajorBreakfast commented 7 years ago

See comment above

WoH commented 7 years ago

Yeah, just because a lot of things are done suboptimally, we should 100% extend bad practices all over the app. I agree.

gyachdav commented 7 years ago

boyz plz chill the language

MajorBreakfast commented 7 years ago

@gyachdav It's a bit heated but we didn't swear ;)

@WoH I agree. We should name things consistently and I propose to prefix all others. I can provide a PR for that. Shall I?

WoH commented 7 years ago

I am working on it.

MajorBreakfast commented 7 years ago

Prefix selectors with poke- and remove prefixes from classes then? I don't like it but I'm fine with it if it is consistent.

MajorBreakfast commented 7 years ago

We should make a folder for each component while we're at it. The poke-details/ folder currently holds a whole bunch of components

WoH commented 7 years ago

Already done, this was really bugging me aswell. Just like pipes and models in component subfolders.

MajorBreakfast commented 7 years ago

For reference to for anyone who reads this in the future: https://github.com/PokemonGoers/Catch-em-all/pull/112 (PR for naming conventions)