Closed MajorBreakfast closed 7 years ago
Looks good to me
I'm merging this now.
@WoH To address your concern: My response was "The tag name/selector should mirror the class name. Tags cannot be scoped so prefixing them makes sense". I'm merging this due to there being a lot of classes in the project that are named my way. Nevertheless I can be swayed on that. But then we should consistently rename all of them. I won't do that myself because I like the names how they are right now. So feel free to rename them as you feel fit.
I am requesting changes for good reason.
See comment above
Yeah, just because a lot of things are done suboptimally, we should 100% extend bad practices all over the app. I agree.
boyz plz chill the language
@gyachdav It's a bit heated but we didn't swear ;)
@WoH I agree. We should name things consistently and I propose to prefix all others. I can provide a PR for that. Shall I?
I am working on it.
Prefix selectors with poke-
and remove prefixes from classes then? I don't like it but I'm fine with it if it is consistent.
We should make a folder for each component while we're at it. The poke-details/
folder currently holds a whole bunch of components
Already done, this was really bugging me aswell. Just like pipes and models in component subfolders.
For reference to for anyone who reads this in the future: https://github.com/PokemonGoers/Catch-em-all/pull/112 (PR for naming conventions)
…webpack)