Naming conventions - Githubissues

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)

9 stars 7 forks source link

Naming conventions #112

Closed WoH closed 8 years ago

WoH commented 8 years ago

[x] Extract nested components, models and pipes.
[x] Prefix selectors with poke-
[x] Component Names according to conventions (and without the selector prefix)
[x] import statements
[x] Decorators
[x] constructors
[x] whitespace

angular.io/styleguide

MajorBreakfast commented 8 years ago

I'm pulling this now an see browse it through. Will respond in <10min

MajorBreakfast commented 8 years ago

[x] We should make selector consistently the first property in @Component
[ ] <poke-filter> has no selector
[x] Selectors for <map>, <nav-sidebar>, <navbar> should be prefixed with poke-

WoH commented 8 years ago

I agree, was doing this while you were reviewing I guess :) Just like the Decorator placement and the empty line between external and internal imports and the default constructors

philbu commented 8 years ago

Sorry for making merge conflicts. ;)

MajorBreakfast commented 8 years ago

Updated list above. Only selector for <filter> still missing. Good work!

WoH commented 8 years ago

@philbu np @MajorBreakfast it won't need a selector and I think it could encourage someone to use it if i added one, that's why I didn't. Opinions?

philbu commented 8 years ago

It's not necessary but everyone who works actively on this project won't use it. You can decide.

MajorBreakfast commented 8 years ago

I'm for adding a selector to every component because of this: named-selector

It's convenient for inspecting the page.

MajorBreakfast commented 8 years ago

I just checked all parts of the application and everything works.

You should add the missing selector, otherwise clear to merge. Good work!

MajorBreakfast commented 8 years ago

We should merge this quickly as it breaks pretty much any other possible PR :)

WoH commented 8 years ago

@philbu Do you agree with the refactor?

philbu commented 8 years ago

Yes, does look cleaner and more consistent