Closed WoH closed 8 years ago
I'm pulling this now an see browse it through. Will respond in <10min
selector
consistently the first property in @Component
<poke-filter>
has no selector<map>
, <nav-sidebar>
, <navbar>
should be prefixed with poke-
I agree, was doing this while you were reviewing I guess :) Just like the Decorator placement and the empty line between external and internal imports and the default constructors
Sorry for making merge conflicts. ;)
Updated list above. Only selector for <filter>
still missing. Good work!
@philbu np @MajorBreakfast it won't need a selector and I think it could encourage someone to use it if i added one, that's why I didn't. Opinions?
It's not necessary but everyone who works actively on this project won't use it. You can decide.
I'm for adding a selector to every component because of this:
It's convenient for inspecting the page.
I just checked all parts of the application and everything works.
You should add the missing selector, otherwise clear to merge. Good work!
We should merge this quickly as it breaks pretty much any other possible PR :)
@philbu Do you agree with the refactor?
Yes, does look cleaner and more consistent
angular.io/styleguide