Fix: Rarity rating gets cut off

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)

9 stars 7 forks source link

Fix: Rarity rating gets cut off #113

Closed johartl closed 8 years ago

johartl commented 8 years ago

Fixes #110

MajorBreakfast commented 8 years ago

Looks good.

mfkaptan commented 8 years ago

Hey @johartl I just pulled your branch fix-pokename-size and did a rebuild. This is what I get for iphone 6 (Everything looks ok)

And this is for iphone 5:

Is something wrong with my settings? Could you check this before merging?

johartl commented 8 years ago

The only thing I did was decreasing the font size and I thought that would cover all smaller devices. I guess we need to scale the font size depending on the available screen width. I'm going to look into it. Thanks for checking!

sacdallago commented 8 years ago

Sometimes these kinds of things are unavoidable. Try to fix as possible, but focus on wrapping up now.

MajorBreakfast commented 8 years ago

Update: In https://github.com/PokemonGoers/Catch-em-all/issues/69 we decided to use the badges common, uncommon, rare instead of stars for rarity. This changes things of course. I think that we should place them somewhere else. Either above or below the picture would be fine

MajorBreakfast commented 8 years ago

Replaced by #122