search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Pokedex details redesign #123

Closed MajorBreakfast closed 7 years ago

MajorBreakfast commented 7 years ago

Note: This also includes the minor change of #116 (postinstall hook)

Implements the design change of #121

This PR is mainly about the broad layout change and improvements in clarity (#120 cryptic glyphs). Minor layout tweaks and tweaks to shapes and colors are not included. We can handle iterative improvements in additional PRs. I'd like to get this merged soon, please don't get hung up on appearance details. I will take your design feedback into account, just not in this PR! :)

pokedex-redesign

MajorBreakfast commented 7 years ago

comparison

MajorBreakfast commented 7 years ago

subtle-colors

Okay, now we're back to subtle colors again. PLZ review my code.

MajorBreakfast commented 7 years ago

I've added a commit that takes care of #119 (Removal of creative commons license statement)

WoH commented 7 years ago

Good:

Not so good:

The stats could be contained within a card maybe? I like cards...

MajorBreakfast commented 7 years ago

2 Different topics in one PR

Jep, I'd fix it, but I don't think it's worth the effort

WoH commented 7 years ago

No, just try to avoid it in the future

sacdallago commented 7 years ago

I still don't like the clouds 🙈 If you get rid of that and use some rectangles, in my view, it looks sexy ( @WoH ).

About two issues in one PR, I agree with both points: better not do this next time, but too much to do now to close this and open two separate ones IF this PR is ok for both problems

MajorBreakfast commented 7 years ago

@WoH Will do.

@sacdallago I'll take a look at getting rid of the clouds later. It's a bit tricky. Simply removing the radii doesn't work. It looked bad when I tried it. Maybe I get an idea later.

@philbu Thx for telling me that the current Pokemon image in the evolutions chart wasn't square. The problem was cause by the colored border.

I'm merging this now. Thanks for all the feedback.