Closed MajorBreakfast closed 7 years ago
Note: This PR is a lot more than this simple layout. I've refactored the layout of the sightings card and a lot of related stuff.
You may review it now! :) Let's get it merged
Mucho cool!
There's 2 or more things going on in one PR again ...
more things going on in one PR
@WoH There's not. I never touched anything that wasn't related. If you want, you can think about this PR as "Refactor POIs so that Mobs can be displayed". If I had left things as they were, it would have been a mess. Nevertheless, plz review. I'd like to get this in. ;)
@MajorBreakfast I would've liked to have the initial refractoring in a PR.
I'd want @johartl to comment, the POI Cards are his baby.
I would've liked to have the initial refractoring in a PR.
@WoH I've changed the name. The actual Mob card is the least part of this PR. However, there is little value in separating it out. I agree that @johartl should comment.
I'm going to merge this this evening unless there are objections to any of the things I changed. The code is clean and I tested all affected app parts thoroughly, so it should be fine.
Regarding the discussion about too many things in one PR. I mostly agree that all changes focus around the mob card with the exception of renaming PokeSighting, PokeAttack, PokeGender, PokeMob, and some more. Personally, I think you could have done this in a separate PR.
@johartl Plz update your review.
Clear to merge? Any other wishes?
WIP