search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Refactor POIs so that Mobs can be displayed #131

Closed MajorBreakfast closed 7 years ago

MajorBreakfast commented 7 years ago

WIP

MajorBreakfast commented 7 years ago

mob-card

Note: This PR is a lot more than this simple layout. I've refactored the layout of the sightings card and a lot of related stuff.

You may review it now! :) Let's get it merged

gyachdav commented 7 years ago

Mucho cool!

WoH commented 7 years ago

There's 2 or more things going on in one PR again ...

MajorBreakfast commented 7 years ago

more things going on in one PR

@WoH There's not. I never touched anything that wasn't related. If you want, you can think about this PR as "Refactor POIs so that Mobs can be displayed". If I had left things as they were, it would have been a mess. Nevertheless, plz review. I'd like to get this in. ;)

WoH commented 7 years ago

@MajorBreakfast I would've liked to have the initial refractoring in a PR.

WoH commented 7 years ago

I'd want @johartl to comment, the POI Cards are his baby.

MajorBreakfast commented 7 years ago

I would've liked to have the initial refractoring in a PR.

@WoH I've changed the name. The actual Mob card is the least part of this PR. However, there is little value in separating it out. I agree that @johartl should comment.

MajorBreakfast commented 7 years ago

I'm going to merge this this evening unless there are objections to any of the things I changed. The code is clean and I tested all affected app parts thoroughly, so it should be fine.

johartl commented 7 years ago

Regarding the discussion about too many things in one PR. I mostly agree that all changes focus around the mob card with the exception of renaming PokeSighting, PokeAttack, PokeGender, PokeMob, and some more. Personally, I think you could have done this in a separate PR.

MajorBreakfast commented 7 years ago

@johartl Plz update your review.

MajorBreakfast commented 7 years ago

Clear to merge? Any other wishes?