Closed WoH closed 7 years ago
Wow, that is ... a lot.
@sacdallago and @gyachdav should get their seminar statistics right - before you basically remove all our code ... ;)
Will review this tomorrow, wanna do this in one go before falling asleep...
I left everything in tact whenever possibe. I moved a lot of the stuff from /app... to /src, but I also had to scope the styles differently and as soon as that happens, github doesn't count it as moving a -> b but as removing a and adding b.
Also, when did statistics begin to matter? Just slip the build folder into one of your commits, add one to remove it and merge it before I can retaliate.
First: Good work! But...
We're loosing scoped styles?
Hey guys will this PR fix the ERROR NativeStorageError
? It's like super annoying!
I guess that's why the map is not loading? Maybe it also has to do with maxing out the requests at mapbox.
Just please merge if this is fine and fixes issues, we are like super late on schedule.
@sacdallago thanks for reminding me of that. However, this is not related to RC1 and this PR is already not the smallest. I opened another one that tackles that issue. Once that PR is merged and #136 is solved, the map will load and load without errors.
Can this finally be merged?
Waiting for @johartl to confirm or add his thoughts.
I will have a look today. Sorry for the delay.
You need both I think, I was just about to fix that :D
@johartl Is this good to go? I re-enabled everything that I had to work around and I think this is ready now.
Edit: The agressive caching of the ServiceWorker should also massively decrease the data consumption.
Please give me some more time. Currently the Docker build is not working and I also want to test the Android build before merging it.
@sacdallago is coming after us, I agree we shouldn't make any overzealous moves though.
@WoH you bet I am
@sacdallago I'm sure the last thing you want is a broken Docker build though ;) From my side this PR is good to go now!
@johartl oh, well, you know how to make a man happy, don't you?
^
I will merge as soon as I can conform that it integrates nicely with PM-1
oh wow, this happened
See: https://github.com/PokemonGoers/Catch-em-all/issues/90
Big thanks to @johartl for a lot of his work on Catch-em-all/tree/rc0