search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

ionic RC1 #133

Closed WoH closed 7 years ago

WoH commented 7 years ago

See: https://github.com/PokemonGoers/Catch-em-all/issues/90

Big thanks to @johartl for a lot of his work on Catch-em-all/tree/rc0

AlexanderLill commented 7 years ago

Wow, that is ... a lot.

@sacdallago and @gyachdav should get their seminar statistics right - before you basically remove all our code ... ;)

Will review this tomorrow, wanna do this in one go before falling asleep...

WoH commented 7 years ago

I left everything in tact whenever possibe. I moved a lot of the stuff from /app... to /src, but I also had to scope the styles differently and as soon as that happens, github doesn't count it as moving a -> b but as removing a and adding b.

Also, when did statistics begin to matter? Just slip the build folder into one of your commits, add one to remove it and merge it before I can retaliate.

MajorBreakfast commented 7 years ago

First: Good work! But...

3875822

We're loosing scoped styles?

sacdallago commented 7 years ago

Hey guys will this PR fix the ERROR NativeStorageError? It's like super annoying!

I guess that's why the map is not loading? Maybe it also has to do with maxing out the requests at mapbox.

Just please merge if this is fine and fixes issues, we are like super late on schedule.

WoH commented 7 years ago

@sacdallago thanks for reminding me of that. However, this is not related to RC1 and this PR is already not the smallest. I opened another one that tackles that issue. Once that PR is merged and #136 is solved, the map will load and load without errors.

sacdallago commented 7 years ago

Can this finally be merged?

WoH commented 7 years ago

Waiting for @johartl to confirm or add his thoughts.

johartl commented 7 years ago

I will have a look today. Sorry for the delay.

WoH commented 7 years ago

You need both I think, I was just about to fix that :D

WoH commented 7 years ago

@johartl Is this good to go? I re-enabled everything that I had to work around and I think this is ready now.

Edit: The agressive caching of the ServiceWorker should also massively decrease the data consumption.

johartl commented 7 years ago

Please give me some more time. Currently the Docker build is not working and I also want to test the Android build before merging it.

WoH commented 7 years ago

@sacdallago is coming after us, I agree we shouldn't make any overzealous moves though.

sacdallago commented 7 years ago

@WoH you bet I am

johartl commented 7 years ago

@sacdallago I'm sure the last thing you want is a broken Docker build though ;) From my side this PR is good to go now!

sacdallago commented 7 years ago

@johartl oh, well, you know how to make a man happy, don't you?

WoH commented 7 years ago

^ KappaPride

I will merge as soon as I can conform that it integrates nicely with PM-1

sacdallago commented 7 years ago

oh wow, this happened