PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Websocket proxy #146

Closed johartl closed 7 years ago

johartl commented 7 years ago

Sorry, yet another websocket proxy fix :/ The old proxy middleware we were using did not properly support websockets. I tested this change with PokeMap-2 and the websocket connection was established successfully. For PokeMap-1 the websocket connection is still not working due to https://github.com/PokemonGoers/PokeMap-1/issues/42.

sacdallago commented 7 years ago

Sorry :D yesterday I stopped before publishing the websocket port via nginx as I was having issues on other things and wanted to go step by step.. It's very strange that it works.. VERY strange.. My assumption is that it doesn't make use of the env var I pass it on when building, but now with longer logging I might have time to look into it

johartl commented 7 years ago

My assumption is that it doesn't make use of the env var I pass it on when building

That makes sense as the websocket env variable defaults to the old docker container (which is working just fine) . The bug I fixed with this PR, however, had nothing to do with the setup of the production system. I exclusively tested it with the old docker container so this is something we would've needed to fix anyway ;)