Closed WoH closed 7 years ago
7000 lines added? What is this even doing?
Click the blue things.
I read your blue things. Does this mean now that every contributor has to update the yarn lock file upon installing or removing package dependencies?
This should be majority vote imho. Which probably means 50/50 as it's me and you :laughing: :gun: If you run yarn add that should update both. If you wanna give it a try, merge it, otherwise we can leave this up until everybody and their grandma switched.
no reason to waste time on Yarn at this stage. Keep it for your next project.
You're right. I'll use it for myself, everyone else can run yarn for himself of enjoy the "fun" npm is. Just don't annoy me if your deps are off.
Jezuz @WoH that was some passive-aggressive comment :D It almost wins, if it wasn't for the countless conversations between you and @MajorBreakfast
@sacdallago https://github.com/PokemonGoers/PokeMap-1/issues/40#issuecomment-255590416
I wasted like an hour trying to make npm update after a magic combination of npm prune, rm -rf node_modules and npm cache clean finally did the trick. I was pretty done with that wonderful dependency management at that point. Wasn't meant to sound as passive aggressive as it looks ^^ But it's not the first time we had issues (beta -> rc0) in out team, so that wasn't directed to anyone specifically but I just don't want to deal with that any more.
@woh I will do my best not to annoy you. Make sure you do the same.
@gyachdav I'll try to not sound like a pissed-off toddler who had his candies stolen. WIll that work? :sweat:
Hehe, opinionated programming :)
I heard about yarn before and I checked it out now. What I've seen are definite improvements to npm while not splitting the ecosystem because it still uses the npm registry (Due to its chaching it even eases the server load on the registry). What I'm not so sure about is whether a lock file should be in the repo. Since we're a leaf package it seems to be okay. But it's IMO a definite no-no for non-leaf packages. There yarn.lock
should be in the .gitignore
. Otherwise all the version resolution magic would go down the drain. </major-breakfast-rumbling-in-an-already-closed-issue>
No npm fanboys were harmed :laughing: