search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Add Yarn Lockfile #150

Closed WoH closed 7 years ago

WoH commented 7 years ago

No npm fanboys were harmed :laughing:

johartl commented 7 years ago

7000 lines added? What is this even doing?

WoH commented 7 years ago

Click the blue things.

WoH commented 7 years ago

More blue things:

johartl commented 7 years ago

I read your blue things. Does this mean now that every contributor has to update the yarn lock file upon installing or removing package dependencies?

WoH commented 7 years ago

This should be majority vote imho. Which probably means 50/50 as it's me and you :laughing: :gun: If you run yarn add that should update both. If you wanna give it a try, merge it, otherwise we can leave this up until everybody and their grandma switched.

gyachdav commented 7 years ago

no reason to waste time on Yarn at this stage. Keep it for your next project.

WoH commented 7 years ago

You're right. I'll use it for myself, everyone else can run yarn for himself of enjoy the "fun" npm is. Just don't annoy me if your deps are off.

sacdallago commented 7 years ago

Jezuz @WoH that was some passive-aggressive comment :D It almost wins, if it wasn't for the countless conversations between you and @MajorBreakfast

WoH commented 7 years ago

@sacdallago https://github.com/PokemonGoers/PokeMap-1/issues/40#issuecomment-255590416

I wasted like an hour trying to make npm update after a magic combination of npm prune, rm -rf node_modules and npm cache clean finally did the trick. I was pretty done with that wonderful dependency management at that point. Wasn't meant to sound as passive aggressive as it looks ^^ But it's not the first time we had issues (beta -> rc0) in out team, so that wasn't directed to anyone specifically but I just don't want to deal with that any more.

gyachdav commented 7 years ago

@woh I will do my best not to annoy you. Make sure you do the same.

WoH commented 7 years ago

@gyachdav I'll try to not sound like a pissed-off toddler who had his candies stolen. WIll that work? :sweat:

MajorBreakfast commented 7 years ago

Hehe, opinionated programming :)

MajorBreakfast commented 7 years ago

I heard about yarn before and I checked it out now. What I've seen are definite improvements to npm while not splitting the ecosystem because it still uses the npm registry (Due to its chaching it even eases the server load on the registry). What I'm not so sure about is whether a lock file should be in the repo. Since we're a leaf package it seems to be okay. But it's IMO a definite no-no for non-leaf packages. There yarn.lock should be in the .gitignore. Otherwise all the version resolution magic would go down the drain. </major-breakfast-rumbling-in-an-already-closed-issue>