search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Fix poke-type component plural madness #155

Closed MajorBreakfast closed 7 years ago

MajorBreakfast commented 7 years ago

Now the <poke-type> component simply takes a string property type, not an array. Notice, that this PR does not lack any files. This has been partially implemented before. Not sure why it even worked though.

Note: I've removed the type name and type color definitions from the api service as its static data not from the api

WoH commented 7 years ago

I wrapped other static data (ProjectGroups) in a Service. It's a bit of over-engineering, but we shouldn't mix both.

MajorBreakfast commented 7 years ago

Have you merged this already? If not, then I'd like to merge this PR first. Then you can pull and integrate your service. May I merge?

WoH commented 7 years ago

The service has been in there for a while.

https://github.com/PokemonGoers/Catch-em-all/blob/develop/ionic2/src/services/project-groups.service.ts

MajorBreakfast commented 7 years ago

Go to go?