Closed WoH closed 8 years ago
Using the controls with the mouse and touch now works perfectly. Good job
Bug: Interaction with the menu button in the navigation bar is broken. The menu won't stay open properly.
Bug: When the content of the shown component is longer than the height of the popover, it is extended to the bottom of the screen and further down to the floor of the room I am currently sitting in.
This can be checked on the pokemon-filter branch. How can we proceed with this? Can you maybe fix that?
Bug: Interaction with the menu button in the navigation bar is broken. The menu won't stay open properly.
Please elaborate. If the popover is open you're not supposed to be able to access the navigation menu directly. The first tap next to the popover closes it, then you can use the navbar to navigate.
Bug: When the content of the shown component is longer than the height of the popover, it is extended to the bottom of the screen and further down to the floor of the room I am currently sitting in. This can be checked on the pokemon-filter branch. How can we proceed with this? Can you maybe fix that?
Explanation: To avoid issues with ionic, we render the tab view after the Popover is Loaded so the ionic event ionChange registers properly. This means ionic doesn't account for the space needed for the tab content to display on screen when it calculates the distance needed to the bottom. Therefore, we now pass the popover additional styling using the popover class that I pass to the Popover. Right now I was only considering the web view that should be similar to android and defined a global style (top: -500px). I am just trying to make the tools available for everyone else to maybe refine the styling and implement custom behavior for other platforms (iOS and wp8 seem very similar in that regard, you can look at this by going to url/ionic-lab) using the platform specific styles.
Edit: Added that to the todo list at the top, maybe someone can create an issue and link this wall of text.
Also, I noticed we should make the popover a bit wider and maybe dry it out by removing or shortening the text. As much as I enjoy reading it, it takes up too much space on a smaller screen
Posted the issue but I don't want to wait for the final styling. I'll merge this until we rewrite this as a simple component like @MajorBreakfast suggested.