Closed philbu closed 7 years ago
If you solve the merge conflict and keep my new hook intact this should be good to go.
Edit: Please change the background color though.
I did a bit of styling and fixed the badges in the Pokémon details view. I created two options for the badges. First one is done with the <ion-badge>
tag as before. For the second one the tag has been removed and will be just a <div>
then.
Any Preferences?
2/3 with the badge color corresponding to the the label color
I like the div better. However, can you make the width of the badge a few pixels smaller.
Sure. The dimensions are a bit weird anyway. I will look into it this evening.
Fixed the new image sources. It isn't .icon anymore. Instead it is .gifIcon, .pngIcon and .svgIcon. Unfortunately the data team hasn't uploaded pictures for svgIcon yet and the pngIcons aren't highres right now.
Is this good to merge?
@philbu I will merge this now. I really need some of the changes in here to finish the POI card.