Closed WoH closed 7 years ago
Have you tried running the Docker build? For me, the cordova.js file was missing. I don't know who is supposed to generate it but apparently ionic build browser
doesn't do the trick.
I'll have to look into the docker build, ionic build browser is working as intended and everything required ends up in platforms/browser/www
Edit: Using the new directory now
@johartl Can you look into the API Endpoint stuff (ConfigService)? I worked around that to make it work locally, maybe you can reintroduce the env variables?
Environment variables are fixed. Docker should also work.
Please avoid relying on any globally installed packages (e.g. npm install -g cordova
) and install them locally instead. I also removed the rm -rf node_modules
line you've introduced. This is just gonna give us painfully long Travis builds. If there should be any issues with npm installs you can always just clear the cache.
I had to do it one time to solve an issue with npm. However, keeping it is not neccessairy, I agree. Same thing goes for the cordova. previously, the builds were failing because n_m/.bin/ionic build would try to get plugins using cordova.
when is the MVP out?
This will be merged after the beta probably. It is in a solid state but we have to take care of enough things so we don't want to add additional complexity for now, since the migration involves a completely new build process and breaking changes in both Ionic and Angular
Updated
@sacdallago This issue requires a lot of experience with ionic 2. Should @Georrgi still want to contribute we could find something easier for him. I'm unassigning him here since @WoH has it covered (See rc1 branch). I hope that's okay.
I didn't even see this until now, I agree. Me and @johartl are/will be doing fine here.
Updated.
Issues:
Additional (not MVP):
Abandoned:
Not Part of the PR:
Laugh at my progress here