search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

migrate to Ionic RC1 #90

Closed WoH closed 7 years ago

WoH commented 7 years ago

Lifecycle Events Renamed Renamed ionViewLoaded to ionViewDidLoad Removed ionViewDidUnload Removed fireOtherLifecycles from ViewController

  • [x] Scope CSS

Add selectors to each of your components that are used as pages. These selectors will be used for scoped sass. With this change this is now the proper way to scope your sass for an individual page.

Issues:

Additional (not MVP):

Abandoned:

Not Part of the PR:

Laugh at my progress here

johartl commented 7 years ago

Have you tried running the Docker build? For me, the cordova.js file was missing. I don't know who is supposed to generate it but apparently ionic build browser doesn't do the trick.

WoH commented 7 years ago

I'll have to look into the docker build, ionic build browser is working as intended and everything required ends up in platforms/browser/www

Edit: Using the new directory now

WoH commented 7 years ago

@johartl Can you look into the API Endpoint stuff (ConfigService)? I worked around that to make it work locally, maybe you can reintroduce the env variables?

johartl commented 7 years ago

Environment variables are fixed. Docker should also work. Please avoid relying on any globally installed packages (e.g. npm install -g cordova) and install them locally instead. I also removed the rm -rf node_modules line you've introduced. This is just gonna give us painfully long Travis builds. If there should be any issues with npm installs you can always just clear the cache.

WoH commented 7 years ago

I had to do it one time to solve an issue with npm. However, keeping it is not neccessairy, I agree. Same thing goes for the cordova. previously, the builds were failing because n_m/.bin/ionic build would try to get plugins using cordova.

gyachdav commented 7 years ago

when is the MVP out?

WoH commented 7 years ago

This will be merged after the beta probably. It is in a solid state but we have to take care of enough things so we don't want to add additional complexity for now, since the migration involves a completely new build process and breaking changes in both Ionic and Angular

WoH commented 7 years ago

Updated

MajorBreakfast commented 7 years ago

@sacdallago This issue requires a lot of experience with ionic 2. Should @Georrgi still want to contribute we could find something easier for him. I'm unassigning him here since @WoH has it covered (See rc1 branch). I hope that's okay.

WoH commented 7 years ago

I didn't even see this until now, I agree. Me and @johartl are/will be doing fine here.

WoH commented 7 years ago

Updated.