PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)

9 stars 7 forks source link

Popover is shown out of screen bounds #92

Closed AlexanderLill closed 7 years ago

AlexanderLill commented 7 years ago

The popover is not completely on the screen, but about 80% are below the shown screen (see screenshot).

I am using the current release from HockeyApp (Oct 3rd, 1:04am) which is the following commit: Merge pull request #91 from PokemonGoers/poke-rarity (01a06cbb6e08a8028fda087ccae5fb836ef44666)

screenshot_20161003-011050

sacdallago commented 7 years ago

Can you reproduce this also on web?

AlexanderLill commented 7 years ago

It also happens when I use the Chrome browser on my android. I can't reproduce it with Chromium on my desktop though, even if I switch to the mobile view in the Developer Tools.

Not sure if this should be investigated if we replace the implementation of the popover anyway. If we want to investigate this, we would need more android users that try this.

sacdallago commented 7 years ago

Happens on mine as well: Note 4, un-rooted Android v6.0.1

Can try this evening on: A Nexus 7 and a Tab S v2 8 and let you know if it's the case there as well. Seems to be Android bound

philbu commented 7 years ago

Same on LG G4 with Android 6.0

sacdallago commented 7 years ago

I'll add something to this:

now the button gets hidden by the tile layers! Are you adding the map before or after the button? Also worth looking into the z-index of the button.

Edit: you can reproduce this by zooming in or out.

johartl commented 7 years ago

@sacdallago The bug is caused by https://github.com/PokemonGoers/PokeMap-1/issues/35 Edit: .. was caused. It's fixed now :)

WoH commented 7 years ago

For the builds we can fix the position, however this is just a workaround. I'll look at this again once we are on RC0

philbu commented 7 years ago

108 Workaround by using modal. But there is still a bug.

WoH commented 7 years ago

Fixed: https://github.com/PokemonGoers/Catch-em-all/commit/a3b8717f883849aa91c986c625cbeba8285b7302