search

PokemonGoers / Catch-em-all

Now that we have tons of data about Pokemon (what they are, where they are, what’s their relationship, what they can transform into, which attacks they can perform, aso) we want to integrate it all into a comprehensive website. This website should contain sections about each Pokemon and its details. Additionally, the website should register the user’s location and tell the user how close is that the predicted pokemon to him/her. Additionally you will be incorporating the apps that were created by project B,C and D into the website. Your group will need to create automated builds and testing for this apps and use continuous integration to pull in new changes in the code repositories. Apps from projects B-D should be packaged and made available on NPM. Ideally when you completed these tasks the webapp component would integrate the apps by “requiring’ them. Here is a possible user story: when a user opens the website or the app the current location of the user will be shown. Additionally, the website/app will show automatically where the pokemons that are currently active are and where the pokemons that we predict to active in the nearest future (i.e. within half a day) will be located (all of this will be available from the app developed in project D). Hopefully, the website will be somewhat crowded by that data. Then, there needs to be a menu bar or something available (e.g. above the map or on the right side to it) that will list currently active or predicted pokemons. Clicking on one of them will make other pokemons on the map disappear, except of this clicked one. Separate web pages would allow the search and presentation of individual Pokemons and the information we gathered about them, including third party data (project A) and twitter analysis (project C)
9 stars 7 forks source link

Update about-people.ts #95

Closed sacdallago closed 7 years ago

sacdallago commented 7 years ago

@gyachdav @goldbergtatyana @juanmirocks opinions?

sacdallago commented 7 years ago

Also @lrrichter @T1mK do the links work for you :smiley: ?

Edit: You can see the final result here navigating to 'About' from the top left :)

goldbergtatyana commented 7 years ago

Wow, I very much like how @PokemonGoers/catch-em-all acknowledged everyone!

My feedback: I really like the about page of our prev project https://got.show/about

It shows a picture of all and lists the names in a compact way. If we could also have a picture on one side and the project description on the other side of the page, and the contributors listed in a couple of columns, I think it would be great!

The picture of our group can be downloaded from https://rostlab.org/~goldberg/JST_WS201617_v2.jpg

Another thing that is missing is Iteratec logo and a thank you for sponsoring the course. The logo of Iteratec can be downloaded from https://rostlab.org/~goldberg/Iteratec.jpg

Finally, I would edit the description text to the following: On July 6th of this year, Niantic released the new location-based augmented reality title PokemonGo. The game took the world by storm and is now installed on 5% of smartphones in the US. In the game, players are using their smartphones to locate Pokemon - cute and cuddly virtual creatures that after being captured and nurtured turn into fearless fighters in the name of your ambition to level up.

In the real world Pokemons appear at random places and only for a short period of time. While firing up your PokemonGo app and starting to randomly look for a Pokemon that may pop up nearby may be a fun thing to do, we thought it could be nice if we do not leave things to random chance. Instead, we are intelligently guessing when and where our Pokemons will pop up.

However, not sure how ok it is to use PokemonGo.

sacdallago commented 7 years ago

Oh. How I miss not being on that photo :cry:

philbu commented 7 years ago

@goldbergtatyana I think PokemonGo is valid in our text. Otherwise journalists wouldn't be able to write about it. I also prefer your text and will change it. @sacdallago Is it okay for you, when I commit my changes to your PR?

sacdallago commented 7 years ago

@philbu of course! :) I really only intended to change the links, but if this sparks a set of other modifications, just use it

goldbergtatyana commented 7 years ago

I know @sacdallago 😢 So we photoshop you in?! 😀

goldbergtatyana commented 7 years ago

Btw, what you all think of photoshopping everyone who is not on the pic? Of course, after them giving us their ok hot doing so.

philbu commented 7 years ago

If someone is good enough to photoshop it, it's fine for me. Unfortunately I'm not good at "photoshopping"

philbu commented 7 years ago

How should we formulate the "thank you" section (included in my commit)? Any ideas for improvement?

sacdallago commented 7 years ago

@philbu it's concise and direct, I like it. @goldbergtatyana @gyachdav ?

goldbergtatyana commented 7 years ago

uhm, im not a big friend of "you guys made this project possible". There were more guys and gals involved :))

philbu commented 7 years ago

Does someone still want to change sth on the about page? Otherwise I will merge it.

gyachdav commented 7 years ago

We need Iteratec to approve the mention. Is there a public link I can send them?

AlexanderLill commented 7 years ago

@sacdallago @gyachdav here: https://github.com/PokemonGoers/Catch-em-all/blob/links-in-about/ionic2/app/pages/about/about.page.html

But the page currently only includes the logo of them

How about we write »We want to thank our sponsor Iteratec for providing the domain, hosting and interesting insights into their company.« (@philbu)

sacdallago commented 7 years ago

I suggest we merge this, we send them the link to the svc on docker cloud and ask them if it's fine for them.

Currently the API is down, so I'm not sure it's safe to forward them the link right now-now, being that they won't see much (but the about page should still be working).

AlexanderLill commented 7 years ago

@sacdallago merged and online in the docker live-demo! API is still down though.

sacdallago commented 7 years ago

I like it :)

goldbergtatyana commented 7 years ago

I like the About page, too! A lot!

Comments:

Most likely this is still not the last round of a review, yet very looking forward to the result 😄

AlexanderLill commented 7 years ago

As this PR is unfortunately closed by now, see issue #100 ( @goldbergtatyana )