Closed sacdallago closed 7 years ago
Also @lrrichter @T1mK do the links work for you :smiley: ?
Edit: You can see the final result here navigating to 'About' from the top left :)
Wow, I very much like how @PokemonGoers/catch-em-all acknowledged everyone!
My feedback: I really like the about page of our prev project https://got.show/about
It shows a picture of all and lists the names in a compact way. If we could also have a picture on one side and the project description on the other side of the page, and the contributors listed in a couple of columns, I think it would be great!
The picture of our group can be downloaded from https://rostlab.org/~goldberg/JST_WS201617_v2.jpg
Another thing that is missing is Iteratec logo and a thank you for sponsoring the course. The logo of Iteratec can be downloaded from https://rostlab.org/~goldberg/Iteratec.jpg
Finally, I would edit the description text to the following: On July 6th of this year, Niantic released the new location-based augmented reality title PokemonGo. The game took the world by storm and is now installed on 5% of smartphones in the US. In the game, players are using their smartphones to locate Pokemon - cute and cuddly virtual creatures that after being captured and nurtured turn into fearless fighters in the name of your ambition to level up.
In the real world Pokemons appear at random places and only for a short period of time. While firing up your PokemonGo app and starting to randomly look for a Pokemon that may pop up nearby may be a fun thing to do, we thought it could be nice if we do not leave things to random chance. Instead, we are intelligently guessing when and where our Pokemons will pop up.
However, not sure how ok it is to use PokemonGo.
Oh. How I miss not being on that photo :cry:
@goldbergtatyana I think PokemonGo is valid in our text. Otherwise journalists wouldn't be able to write about it. I also prefer your text and will change it. @sacdallago Is it okay for you, when I commit my changes to your PR?
@philbu of course! :) I really only intended to change the links, but if this sparks a set of other modifications, just use it
I know @sacdallago 😢 So we photoshop you in?! 😀
Btw, what you all think of photoshopping everyone who is not on the pic? Of course, after them giving us their ok hot doing so.
If someone is good enough to photoshop it, it's fine for me. Unfortunately I'm not good at "photoshopping"
How should we formulate the "thank you" section (included in my commit)? Any ideas for improvement?
@philbu it's concise and direct, I like it. @goldbergtatyana @gyachdav ?
uhm, im not a big friend of "you guys made this project possible". There were more guys and gals involved :))
Does someone still want to change sth on the about page? Otherwise I will merge it.
We need Iteratec to approve the mention. Is there a public link I can send them?
@sacdallago @gyachdav here: https://github.com/PokemonGoers/Catch-em-all/blob/links-in-about/ionic2/app/pages/about/about.page.html
But the page currently only includes the logo of them
How about we write »We want to thank our sponsor Iteratec for providing the domain, hosting and interesting insights into their company.« (@philbu)
I suggest we merge this, we send them the link to the svc on docker cloud and ask them if it's fine for them.
Currently the API is down, so I'm not sure it's safe to forward them the link right now-now, being that they won't see much (but the about page should still be working).
@sacdallago merged and online in the docker live-demo! API is still down though.
I like it :)
I like the About page, too! A lot!
Comments:
Most likely this is still not the last round of a review, yet very looking forward to the result 😄
As this PR is unfortunately closed by now, see issue #100 ( @goldbergtatyana )
@gyachdav @goldbergtatyana @juanmirocks opinions?