PokemonTCG / pokemon-tcg-data

The data found within the Pokémon TCG API
418 stars 201 forks source link

include ptcgoCode for sv1, sv2, sv3 #476

Closed ajanick3 closed 7 months ago

ajanick3 commented 1 year ago

I noticed that the ptcgoCode is missing from some of the latest sets:

Set id Set ptcgoCode
sv1 SVI
sv2 PAL
sv3 OBF
ajanick3 commented 1 year ago

I'm trying to write a parser for the PTCGL export text, but some of the sets don't include some of the ptcgoCodes.

For example:

4 Charmander OBF 26
1 Charmeleon OBF 27
3 Charizard ex OBF 125
2 Arceus V BRS 122
2 Arceus VSTAR BRS 123
2 Pidgeot ex OBF 164
2 Pidgey OBF 162
1 Mew CEL 11
1 Radiant Charizard CRZ 20

3 Boss's Orders PAL 172
3 Iono PAL 185
3 Colress's Experiment LOR 155
1 Jacq SVI 175
4 Ultra Ball SVI 196
4 Battle VIP Pass FST 225
4 Rare Candy SVI 191
2 Nest Ball SVI 181
1 Escape Rope BST 125
1 Lost Vacuum CRZ 135
1 Super Rod PAL 188
1 Vitality Band SVI 197
1 Choice Belt PAL 176
2 Artazon PAL 171
1 Magma Basin BRS 144

8 Fire Energy 2
2 Double Turbo Energy BRS 151
[
  {
    id: 'sv3-26',
    quantity: 4,
  },
  {
    id: 'sv3-27',
    quantity: 1,
  },
  // ...
]

Since OBF isn't in the sv3 set data, I can't map the code to the id

{
    "id": "sv3",
    "name": "Obsidian Flames",
    "series": "Scarlet & Violet",
    "printedTotal": 197,
    "total": 230,
    "legalities": {
      "unlimited": "Legal",
      "standard": "Legal",
      "expanded": "Legal"
    },
    // "ptcgoCode": "OBF", // adding in this PR
    "releaseDate": "2023/08/11",
    "updatedAt": "2023/08/11 15:00:00",
    "images": {
      "symbol": "https://images.pokemontcg.io/sv3/symbol.png",
      "logo": "https://images.pokemontcg.io/sv3/logo.png"
    }
  }
Teknogrebo commented 10 months ago

I was going to create a pull request with this information (and the new PAR set) but this one has been languishing for 2 months. Would be good to have it integrated!

GG3Hahn commented 10 months ago

This was discussed somewhat discussed in #443. Apparently theres an inconsistency with PTCGL's card codes.