search

PokemonTCG / pokemon-tcg-data

The data found within the Pokémon TCG API
434 stars 202 forks source link

Add MCD23 for match battle 2023 #481

Open tkfnetwork opened 1 year ago

tkfnetwork commented 1 year ago

This PR adds the McDonalds 2023 collection.

Not sure the process for images?

Cealgair commented 1 year ago

I think you should add the expanded and unlimited legalities to each card and to the set. Otherwise, great job!

tkfnetwork commented 1 year ago

I think you should add the expanded and unlimited legalities to each card and to the set. Otherwise, great job!

Ah ok, I was only able to find information saying that standard was legal. Do we assume expanded and unlimited are legal until told otherwise? Is there a state for that, or the absence of the property is indication? Thanks in advance!

Cealgair commented 1 year ago

Do we assume expanded and unlimited are legal until told otherwise?

For unlimited: yes, the only cards that are not currently marked as unlimited legal are the ones that have a rule printed on them saying that they cannot be played in tournaments.

For expanded, I'd say that if a card has a regulation mark and is not banned, then it should be expanded legal. And besides, these cards are reprints of cards that we already know to be expanded legal anyway.

tkfnetwork commented 1 year ago

Do we assume expanded and unlimited are legal until told otherwise?

For unlimited: yes, the only cards that are not currently marked as unlimited legal are the ones that have a rule printed on them saying that they cannot be played in tournaments.

For expanded, I'd say that if a card has a regulation mark and is not banned, then it should be expanded legal. And besides, these cards are reprints of cards that we already know to be expanded legal anyway.

Fantastic, thanks for explaining! Have updated in https://github.com/PokemonTCG/pokemon-tcg-data/pull/481/commits/ea38968f5e3a17b876df5272031b078454d72500

jparanada commented 1 year ago

Regarding images, here they are (733x1024, and the same ones PkmnCards will use): https://cdn.malie.io/file/malie-io/art/scans/submissions/m23_en.zip