search

PokemonTCG / pokemon-tcg-data

The data found within the Pokémon TCG API
449 stars 209 forks source link

Add Numberless Energy set data #516

Open Pepper0ni opened 9 months ago

Pepper0ni commented 9 months ago

Attempt 2 of #260 , with some changes to bring things in line with PTCGO decklist exports.

Images exist in the old PR but need re-sorting, all numberless energy should be accounted for now.

Compared to the old PR this PR uses numbers for the energy, like PTCGO decklists do, and gives them codes which they had, or for older sets some in the same style as the ones that existed. Also like PTCGO, where 2 energy sets appeared in a gen they were merged into a single set with the second art counting after the first.

Cealgair commented 9 months ago

I think there are a few duplicate cards in the Sun and Moon block, since this api put half of the unnumbered basic energies from that block in sm1. @adback03 what would be the best way to address this?

Pepper0ni commented 9 months ago

Due to discoveries involving PTCGL, and PTCGO being inconsistent with it's own numbering, I decided to again use type letters for card IDs based on the logic that as there is no correct way to number the numberless energy, it should be up to the programmer to convert it to their needs

Pepper0ni commented 9 months ago

https://drive.google.com/file/d/18Bz2hPBj7KTm4qLBlmO_jXruvZaI8FEQ/view?usp=sharing a link to the image files