PokemonTCG / pokemon-tcg-data

The data found within the Pokémon TCG API
416 stars 200 forks source link

Title set file has incorrect total? #535

Open ThuGie opened 2 months ago

ThuGie commented 2 months ago

I might have it wrong but total is the amount with the extra's ? "id": "swshp", "name": "SWSH Black Star Promos", "series": "Sword & Shield", "printedTotal": 307, "total": 304,

And

"id": "svp", "name": "Scarlet & Violet Black Star Promos", "series": "Scarlet & Violet", "printedTotal": 102, "total": 75,

So total should never be lower then printedTotal right ? At least it seems to far all the others, so i would assume these 2 are incorrect ?

Cealgair commented 2 months ago

With promo sets, there isn't really a total printed on the card, so printedTotal refers to highest number that's printed on any card from that set, which in the case of swshp is higher than the actual total because some numbers were skipped, namely SWSH299, SWSH300 and SWSH301.

With svp in particular, since it's a set that is gradually getting new cards, sometimes when adding new cards we forget to update the total and printedTotal, so those are out of date at the moment (and a few cards are missing alltogether)