PokemonWorkshop / PokemonStudio

Pokémon Studio is a monster taming game editor which helps you to bring your ideas to life, in just a few clicks.
https://pokemonworkshop.com/
Other
105 stars 9 forks source link

Remove RPM build #304

Closed NuriYuri closed 4 months ago

NuriYuri commented 4 months ago

Description

This PR removes the RPM Build.

Our developper doesn't have magic time they can spend on making thing work on each an every distribution in the world. Especially when users of said distributions are not willing to help. Thus I suggest to remove the support of the whole RedHat (which is a toxic company anyway) branch. (Like we're not supporting MacOS Intel branch.)

Palbolsky commented 4 months ago

Je ne suis pas contre mais il y a peut-être un entre deux à trouver. Puisque le problème concerne les binaires de psdk et qu'on a pas la capacité de gérer Fedora et co. en plus de tout ce qu'on gère déjà, on pourrait désactiver psdk sur les distributions de Linux autre que Debian, Ubuntu et SteamOS.

NuriYuri commented 4 months ago

Si on trouve une condition pour détecter fédora on peut simplement désactiver le play button oui.

andykimpe commented 4 months ago

or be careful you 2

you will get a 7 day ban

from the github team

rule it on github and they are very strict about it

it is to speak only and exclusively in English

I myself had posted in French

on a project where the developer was French

although he replied in English

It absolutely doesn't bother her that I write in French

and yet I still got the ban in question

from the github team

They can't all monitor but if they catch you in the act

you will unfortunately have the right to the same ban

at their level that you discuss among yourselves or not

he doesn't really care, he says that the only language allowed on inssu and github pull requests is English

you have the right to do a French-speaking project with a readme in French, they won't tell you anything

but I insist on the fact that the instructions and pull requests must be in English

it's for those who for my part I speak more in French on github

otherwise to answer to disable fedora it is wrong to add the following line in the spec file that you use for creating the rpm

Conflicts: fedora-release

but that will in no way solve the problem when I see your last message nuri and I will reply to you afterwards I understand why it doesn't work on Fedora but I am 90% certain given what you told me that in reality this file is totally incompatible with all RedHat bases

in other words false simply remove the rpm as Pablo says at least for the moment

while I think about the project and provide you with a new packaging

NuriYuri commented 4 months ago

We don't have access to the spec file while using Electron Forge. (If you find something inside this: https://js.electronforge.io/interfaces/_electron_forge_maker_rpm.InternalOptions.MakerRpmConfigOptions.html )

Other than that, I'd like to see proof of what you're saying regarding language in PR. I don't find the word english in any of the ToS of Github, if that was mandatory it should be stated somewhere. Other than that, I've seen PR in Chinese and that repository seem to have a Chinese PR template. If other language were forbidden, that wouldn't be possible to have PR templates in other languages. I guess you got reported for another reason ;)

andykimpe commented 4 months ago

no I can guarantee you it was good for him

but that was 10 years ago they may have changed the rules since then

I wasn't the only one to be concerned at the time there were a lot of complaints from both project developers and users