Pokerole-Software-Development / Pokerole-Data

A repository of Pokerole data in application consumable formats. Key Maintainer: Willowlark
3 stars 5 forks source link

Items cleaned up #41

Closed Willowlark closed 1 year ago

Willowlark commented 1 year ago

Couple of the key changes

(Ignore the index)

9        HeldItems    BattleItem
85       HeldItems         Berry
104      HeldItems     MegaStone
151      HeldItems   MonBoosting
177      HeldItems  TypeBoosting
237      HeldItems      ZCrystal
272      HeldItems              
282       Medicine         Berry
292       Medicine       Healing
307       Medicine        Status
316       Medicine       Vitamin
324      Pokeballs              
328   TrainerItems   
Willowlark commented 1 year ago

Definitely open to comments on the categories and pockets. BattleItem is anything that has a mechanic attached pretty much, generic held items (no category) are out of combat ones like Amulet coin. That said, like 80% of the battle items aren't Core so I don't super care about them (Should they be removed?)

tech-ticks commented 1 year ago

It seems like the "Core" field is either a boolean true or an empty string "", I guess that's not intended? I don't know where some of these items come from (there are items that are neither from PMD nor the main games, so I guess they're just homebrew?), but if you want to keep the non-Core ones, I'd find it a bit cleaner to have a single source field instead of boolean flags that encodes where the item is from as a string, e.g. Core 2.0, PMD 1.1, Homebrew, ...

The HealthRestored field will be great for automation, but it should probably be a number instead of a string.